gh-148651: Fix Py_DECREF(value) leak in _zstd decompressor options#148657
Open
mjbommar wants to merge 1 commit intopython:mainfrom
Open
gh-148651: Fix Py_DECREF(value) leak in _zstd decompressor options#148657mjbommar wants to merge 1 commit intopython:mainfrom
mjbommar wants to merge 1 commit intopython:mainfrom
Conversation
5b72ba3 to
e45b490
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #148651 with DecRef proposed in the original report.
Modules/_zstd/decompressor.cline 113 is missingPy_DECREF(value)before the earlyreturn -1whenPyLong_AsInt(key)fails. The identical code inModules/_zstd/compressor.cline 158 has the fix.Confirmed with refcount test from the original report: before fix, 100 error triggers leak 100 refs; after fix, 0 leaked.
_zstd.ZstdDecompressor()leaks a reference on invalid option key #148651