Skip to content

gh-148286: Fail on new UB in CI #148168

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
StanFromIreland merged 11 commits into from
Apr 9, 2026
Merged

gh-148286: Fail on new UB in CI #148168

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
38ae0c1
Fail on new UB
StanFromIreland Apr 6, 2026
d1a9414
Don't waste CI resources
StanFromIreland Apr 6, 2026
a2a444d
wrong branch:-/
StanFromIreland Apr 6, 2026
46f0582
Run `--with-strict-overflow`
StanFromIreland Apr 6, 2026
cdebb42
Populate suppressions.txt, fix `test_capi` fails
StanFromIreland Apr 6, 2026
1e92881
Just skip `test_capi`
StanFromIreland Apr 6, 2026
00c6488
Move halt on error to fix configure
StanFromIreland Apr 6, 2026
b67defe
Fix suppressions
StanFromIreland Apr 6, 2026
a1a0e7f
Add another suppression
StanFromIreland Apr 6, 2026
8c423e0
Skip `test_faulthandler` too, and oh hey, I fixed that one!
StanFromIreland Apr 8, 2026
fdedac7
Merge branch 'main' into san-ubsan
StanFromIreland Apr 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Populate suppressions.txt, fix test_capi fails
  • Loading branch information
@StanFromIreland
StanFromIreland committed Apr 6, 2026
commit cdebb42864734531006b95759219ee49720edfba
2 changes: 1 addition & 1 deletion .github/workflows/reusable-san.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@ jobs:
|| ''
}}.txt handle_segv=0" >> "$GITHUB_ENV"
else
echo "UBSAN_OPTIONS=${SAN_LOG_OPTION} halt_on_error=1 suppressions=${GITHUB_WORKSPACE}/Tools/ubsan/suppressions.txt" >> "$GITHUB_ENV"
echo "UBSAN_OPTIONS=${SAN_LOG_OPTION} halt_on_error=1 handle_segv=0 handle_sigfpe=0 handle_sigbus=0 suppressions=${GITHUB_WORKSPACE}/Tools/ubsan/suppressions.txt" >> "$GITHUB_ENV"
fi
echo "CC=clang" >> "$GITHUB_ENV"
echo "CXX=clang++" >> "$GITHUB_ENV"
Expand Down
6 changes: 1 addition & 5 deletions Tools/build/compute-changes.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -123,11 +123,7 @@ class Outputs:

def compute_changes() -> None:
target_ref, head_ref = git_refs()
if True:
outputs = Outputs(
run_ubuntu=True,
)
elif os.environ.get("GITHUB_EVENT_NAME", "") == "pull_request":
if os.environ.get("GITHUB_EVENT_NAME", "") == "pull_request":
# Getting changed files only makes sense on a pull request
files = get_changed_files(target_ref, head_ref)
outputs = process_changed_files(files)
Expand Down
21 changes: 21 additions & 0 deletions Tools/ubsan/suppressions.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,2 +1,23 @@
# This file contains suppressions for the UndefinedBehaviour sanitizer.
#
# When adding a suppression, include a comment referencing a GitHub issue
# that describes how to reproduce the race and includes the relevant UBSan
# output.

null:Objects/object.c
bool:Objects/memoryobject.c

# Modules/binascii.c:1243:42: runtime error: left shift of 128 by 24 places cannot be represented in type 'int'
shift:Modules/binascii.c

# Modules/_ctypes/cfield.c:644:1: runtime error: left shift of 1 by 63 places cannot be represented in type 'int64_t' (aka 'long')
shift:Modules/_ctypes/cfield.c

# Modules/_zstd/decompressor.c:598:56: runtime error: applying non-zero offset 18446744073709551615 to null pointer
pointer-overflow:Modules/_zstd/decompressor.c

# Modules/_io/stringio.c:350:24: runtime error: addition of unsigned offset to 0x7fd01ec25850 overflowed to 0x7fd01ec2584c
pointer-overflow:Modules/_io/stringio.c

# Objects/bytesobject.c:1190:25: runtime error: applying zero offset to null pointer
pointer-overflow:Objects/bytesobject.c
Loading