Skip to content

gh-148286: Fail on new UB in CI #148168

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
StanFromIreland merged 11 commits into from
Apr 9, 2026
Merged

gh-148286: Fail on new UB in CI #148168

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
38ae0c1
Fail on new UB
StanFromIreland Apr 6, 2026
d1a9414
Don't waste CI resources
StanFromIreland Apr 6, 2026
a2a444d
wrong branch:-/
StanFromIreland Apr 6, 2026
46f0582
Run `--with-strict-overflow`
StanFromIreland Apr 6, 2026
cdebb42
Populate suppressions.txt, fix `test_capi` fails
StanFromIreland Apr 6, 2026
1e92881
Just skip `test_capi`
StanFromIreland Apr 6, 2026
00c6488
Move halt on error to fix configure
StanFromIreland Apr 6, 2026
b67defe
Fix suppressions
StanFromIreland Apr 6, 2026
a1a0e7f
Add another suppression
StanFromIreland Apr 6, 2026
8c423e0
Skip `test_faulthandler` too, and oh hey, I fixed that one!
StanFromIreland Apr 8, 2026
fdedac7
Merge branch 'main' into san-ubsan
StanFromIreland Apr 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Fail on new UB
  • Loading branch information
@StanFromIreland
StanFromIreland committed Apr 6, 2026
commit 38ae0c129da64469e518ca9a1b233edb01d62d95
2 changes: 1 addition & 1 deletion .github/workflows/reusable-san.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@ jobs:
|| ''
}}.txt handle_segv=0" >> "$GITHUB_ENV"
else
echo "UBSAN_OPTIONS=${SAN_LOG_OPTION}" >> "$GITHUB_ENV"
echo "UBSAN_OPTIONS=${SAN_LOG_OPTION} halt_on_error=1 suppressions=${GITHUB_WORKSPACE}/Tools/ubsan/suppressions.txt" >> "$GITHUB_ENV"
Comment thread
StanFromIreland marked this conversation as resolved.
Comment thread
StanFromIreland marked this conversation as resolved.
fi
echo "CC=clang" >> "$GITHUB_ENV"
echo "CXX=clang++" >> "$GITHUB_ENV"
Expand Down
2 changes: 2 additions & 0 deletions Tools/ubsan/suppressions.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
null:Objects/object.c
bool:Objects/memoryobject.c
Loading