Skip to content

GH-146527: Add more data to GC statistics and add it to PyDebugOffsets #146532

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pablogsal merged 8 commits into from
Mar 28, 2026
Merged

GH-146527: Add more data to GC statistics and add it to PyDebugOffsets #146532

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
37c3d44
Extend statics in the GC
sergey-miryanov Mar 18, 2026
2a04eb4
Add GC stats to _PyDebugOffsets
sergey-miryanov Mar 18, 2026
2b6cfaa
Fix object_visits calculation
sergey-miryanov Mar 18, 2026
2db2df6
Add heap_size and work_to_do
sergey-miryanov Mar 27, 2026
f86796d
Reduce size of stats buffers
sergey-miryanov Mar 27, 2026
5da8800
Revert OBJECT_STAT_INC(object_visits)
sergey-miryanov Mar 28, 2026
d09c49a
Revert duration because we need total duration in tests
sergey-miryanov Mar 28, 2026
0bac6ac
Fix gc_free_threading compilation
sergey-miryanov Mar 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Revert OBJECT_STAT_INC(object_visits)
  • Loading branch information
@sergey-miryanov
sergey-miryanov committed Mar 28, 2026
commit 5da880028354ec27ed83e364c8f02ff3111b27f9
4 changes: 4 additions & 0 deletions Python/gc.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -534,6 +534,7 @@ struct visit_decref_context {
static int
visit_decref(PyObject *op, void *arg)
{
OBJECT_STAT_INC(object_visits);
struct visit_decref_context *ctx = (struct visit_decref_context *)arg;
ctx->stats->object_visits += 1;
_PyObject_ASSERT(ctx->parent, !_PyObject_IsFreed(op));
Expand Down Expand Up @@ -612,6 +613,7 @@ visit_reachable(PyObject *op, void *arg)
struct visit_reachable_context *ctx = (struct visit_reachable_context *)arg;
ctx->stats->object_visits += 1;
PyGC_Head *reachable = ctx->head;
OBJECT_STAT_INC(object_visits);
if (!_PyObject_IS_GC(op)) {
return 0;
}
Expand Down Expand Up @@ -855,6 +857,7 @@ visit_move(PyObject *op, void *arg)
struct visit_reachable_context *ctx = (struct visit_reachable_context *)arg;
PyGC_Head *tolist = ctx->head;
ctx->stats->object_visits += 1;
OBJECT_STAT_INC(object_visits);
if (_PyObject_IS_GC(op)) {
PyGC_Head *gc = AS_GC(op);
if (gc_is_collecting(gc)) {
Expand Down Expand Up @@ -1487,6 +1490,7 @@ struct container_and_flag {
static int
visit_add_to_container(PyObject *op, void *arg)
{
OBJECT_STAT_INC(object_visits);
struct container_and_flag *cf = (struct container_and_flag *)arg;
cf->stats->object_visits += 1;
int visited = cf->visited_space;
Expand Down
Loading