Skip to content

GH-146527: Add more data to GC statistics and add it to PyDebugOffsets #146532

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pablogsal merged 8 commits into from
Mar 28, 2026
+203 −74
Merged

GH-146527: Add more data to GC statistics and add it to PyDebugOffsets #146532

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
37c3d44
Extend statics in the GC
sergey-miryanov Mar 18, 2026
2a04eb4
Add GC stats to _PyDebugOffsets
sergey-miryanov Mar 18, 2026
2b6cfaa
Fix object_visits calculation
sergey-miryanov Mar 18, 2026
2db2df6
Add heap_size and work_to_do
sergey-miryanov Mar 27, 2026
f86796d
Reduce size of stats buffers
sergey-miryanov Mar 27, 2026
5da8800
Revert OBJECT_STAT_INC(object_visits)
sergey-miryanov Mar 28, 2026
d09c49a
Revert duration because we need total duration in tests
sergey-miryanov Mar 28, 2026
0bac6ac
Fix gc_free_threading compilation
sergey-miryanov Mar 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Fix gc_free_threading compilation
  • Loading branch information
@sergey-miryanov
sergey-miryanov committed Mar 28, 2026
commit 0bac6ac5f3a56c61a5dc2978be5697eae574b02c
5 changes: 5 additions & 0 deletions Include/internal/pycore_interp_structs.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -208,8 +208,13 @@ struct gc_generation_stats {
double duration;
};

#ifdef Py_GIL_DISABLED
#define GC_YOUNG_STATS_SIZE 1
#define GC_OLD_STATS_SIZE 1
#else
#define GC_YOUNG_STATS_SIZE 11
#define GC_OLD_STATS_SIZE 3
#endif
struct gc_young_stats_buffer {
struct gc_generation_stats items[GC_YOUNG_STATS_SIZE];
int8_t index;
Expand Down
17 changes: 16 additions & 1 deletion Python/gc_free_threading.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2383,6 +2383,21 @@ gc_collect_internal(PyInterpreterState *interp, struct collection_state *state,
handle_legacy_finalizers(state);
}

static struct gc_generation_stats *
get_stats(GCState *gcstate, int gen)
{
if (gen == 0) {
struct gc_young_stats_buffer *buffer = &gcstate->generation_stats.young;
struct gc_generation_stats *stats = &buffer->items[buffer->index];
return stats;
}
else {
struct gc_old_stats_buffer *buffer = &gcstate->generation_stats.old[gen - 1];
struct gc_generation_stats *stats = &buffer->items[buffer->index];
return stats;
}
}

/* This is the main function. Read this to understand how the
* collection process works. */
static Py_ssize_t
Expand Down Expand Up @@ -2471,7 +2486,7 @@ gc_collect_main(PyThreadState *tstate, int generation, _PyGC_Reason reason)
}

/* Update stats */
struct gc_generation_stats *stats = &gcstate->generation_stats[generation];
struct gc_generation_stats *stats = get_stats(gcstate, generation);
stats->collections++;
stats->collected += m;
stats->uncollectable += n;
Expand Down
Loading