Skip to content

gh-142830: prevent some crashes when mutating sqlite3 callbacks #143245

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
picnixz merged 10 commits into from
Jan 1, 2026
Merged

gh-142830: prevent some crashes when mutating sqlite3 callbacks #143245

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
c2f25b5
gh-142830: convert callback context into a full-fledged `PyObject *`
picnixz Dec 28, 2025
4dd0652
gh-142830: prevent crashes when replacing sqlite3 callbacks
picnixz Dec 28, 2025
f089fb6
fix more crashes and move test where they belong
picnixz Dec 29, 2025
03a61cc
Merge branch 'main' into fix/sqlite/uaf-in-progress-142830
picnixz Dec 29, 2025
8005803
simplify tests
picnixz Dec 29, 2025
d303aed
Revert "gh-142830: convert callback context into a full-fledged `PyOb…
picnixz Dec 31, 2025
89d8e52
Merge branch 'main' into fix/sqlite/uaf-in-progress-142830
picnixz Dec 31, 2025
504ef19
simplify ref-counting
picnixz Dec 31, 2025
f5a639c
revert un-necessary test change
picnixz Dec 31, 2025
f83e29f
simplify casts & assertions
picnixz Jan 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
simplify tests
  • Loading branch information
@picnixz
picnixz committed Dec 29, 2025
commit 80058035011c3edaaa9a49cd81d453d57e1f326a
51 changes: 21 additions & 30 deletions Lib/test/test_sqlite3/test_hooks.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -154,29 +154,25 @@ def test_authorizer_invalid_signature(self):
def test_authorizer_concurrent_mutation_in_call(self):
self.cx.execute("create table if not exists test(a number)")

class Handler:
cx = self.cx
def __call__(self, *a, **kw):
self.cx.set_authorizer(None)
raise ZeroDivisionError("hello world")
def handler(*a, **kw):
self.cx.set_authorizer(None)
raise ZeroDivisionError("hello world")

self.cx.set_authorizer(Handler())
self.cx.set_authorizer(handler)
self.assert_not_authorized(self.cx.execute, "select * from test")

@with_tracebacks(OverflowError)
def test_authorizer_concurrent_mutation_with_overflown_value(self):
_testcapi = import_helper.import_module("_testcapi")
self.cx.execute("create table if not exists test(a number)")

class Handler:
cx = self.cx
def __call__(self, *a, **kw):
self.cx.set_authorizer(None)
# We expect 'int' at the C level, so this one will raise
# when converting via PyLong_Int().
return _testcapi.INT_MAX + 1

self.cx.set_authorizer(Handler())
def handler(*a, **kw):
self.cx.set_authorizer(None)
# We expect 'int' at the C level, so this one will raise
# when converting via PyLong_Int().
return _testcapi.INT_MAX + 1

self.cx.set_authorizer(handler)
self.assert_not_authorized(self.cx.execute, "select * from test")


Expand Down Expand Up @@ -294,21 +290,18 @@ def test_progress_handler_invalid_signature(self):
def test_progress_handler_concurrent_mutation_in_call(self):
self.cx.execute("create table if not exists test(a number)")

class Handler:
cx = self.cx
def __call__(self, *a, **kw):
self.cx.set_progress_handler(None, 1)
raise ZeroDivisionError("hello world")
def handler(*a, **kw):
self.cx.set_progress_handler(None, 1)
raise ZeroDivisionError("hello world")

self.cx.set_progress_handler(Handler(), 1)
self.cx.set_progress_handler(handler, 1)
self.assert_interrupted(self.cx.execute, "select * from test")

def test_progress_handler_concurrent_mutation_in_conversion(self):
self.cx.execute("create table if not exists test(a number)")

class Handler:
cx = self.cx
def __bool__(self):
def __bool__(_):
# clear the progress handler
self.cx.set_progress_handler(None, 1)
raise ValueError # force PyObject_True() to fail
Expand Down Expand Up @@ -466,14 +459,12 @@ def test_trace_handler_invalid_signature(self):
def test_trace_callback_concurrent_mutation_in_call(self):
self.cx.execute("create table if not exists test(a number)")

class Handler:
cx = self.cx
def __call__(self, statement):
# clear the progress handler
self.cx.set_trace_callback(None)
raise ZeroDivisionError("hello world")
def handler(statement):
# clear the progress handler
self.cx.set_trace_callback(None)
raise ZeroDivisionError("hello world")

self.cx.set_trace_callback(Handler())
self.cx.set_trace_callback(handler)
self.cx.execute("select * from test")


Expand Down
Loading