Skip to content

bpo-37101: Improve readability of Filterer.filter(...) with builtins #13683

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
dwvisser wants to merge 6 commits into from
Closed

bpo-37101: Improve readability of Filterer.filter(...) with builtins #13683

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
de38361
bpo-37101: Improve readability of Filterer.filter(...) with efficient…
dwvisser May 30, 2019
cab4226
bpo-37101: Added needed news blurb for changes.
dwvisser May 30, 2019
be78c9c
bpo-37101: Further simplification using getattr. Thanks @zach.ware!
dwvisser May 30, 2019
8c7dc0e
cbo-37101: Changelog comment versionchanged correction 3.9 -> 3.8
dwvisser May 30, 2019
f903dbd
cbo-37101: Removing unnecessary change comment.
dwvisser May 30, 2019
6fb489c
bpo-37101: More standard blurb message.
dwvisser May 30, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 3 additions & 10 deletions Lib/logging/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -801,16 +801,9 @@ def filter(self, record):

Allow filters to be just callables.
"""
rv = True
for f in self.filters:
if hasattr(f, 'filter'):
result = f.filter(record)
else:
result = f(record) # assume callable - will raise if not
if not result:
rv = False
break
return rv
filters = (getattr(f, 'filter', f) for f in self.filters)
return all(f(record) for f in filters) # assume callable - will raise if not
Comment thread
dwvisser marked this conversation as resolved.


#---------------------------------------------------------------------------
# Handler classes and functions
Expand Down
1 change: 1 addition & 0 deletions Misc/NEWS.d/next/Library/2019-05-30-13-02-31.bpo-37101.pJ8FSq.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Improved the efficiency of :mod:`logging` record filtering.