Skip to content

bpo-37101: Improve readability of Filterer.filter(...) with builtins#13683

Closed
dwvisser wants to merge 6 commits into
python:masterfrom
dwvisser:fix-issue-37101
Closed

bpo-37101: Improve readability of Filterer.filter(...) with builtins#13683
dwvisser wants to merge 6 commits into
python:masterfrom
dwvisser:fix-issue-37101

Conversation

@dwvisser
Copy link
Copy Markdown

@dwvisser dwvisser commented May 30, 2019

@the-knights-who-say-ni
Copy link
Copy Markdown

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept your contribution by verifying you have signed the PSF contributor agreement (CLA).

Our records indicate we have not received your CLA. For legal reasons we need you to sign this before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

If you have recently signed the CLA, please wait at least one business day
before our records are updated.

You can check yourself to see if the CLA has been received.

Thanks again for your contribution, we look forward to reviewing it!

Comment thread Lib/logging/__init__.py
Comment thread Lib/logging/__init__.py Outdated
Comment thread Misc/NEWS.d/next/Library/2019-05-30-13-02-31.bpo-37101.pJ8FSq.rst Outdated
Comment thread Lib/logging/__init__.py
@vsajip
Copy link
Copy Markdown
Member

vsajip commented May 31, 2019

Please see my comments on the issue.

@dwvisser
Copy link
Copy Markdown
Author

The performance impact of this change is measurably negative, therefore unacceptable. 😦

Here's the lesson I learned: generators are great for deferring computation, but they don't necessarily beat a focused loop with if- and break- statements in the right places. My code would be acceptable if the only criterion were functional and "tell me what you're doing, not how", but the logging package must also stay out of the way of real applications, performance-wise.

@dwvisser dwvisser closed this May 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants