Skip to content

gh-132097: use a macro for semantically casting function pointers #132406

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
picnixz merged 8 commits into from
Apr 18, 2025
Merged

gh-132097: use a macro for semantically casting function pointers #132406

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
09fb715
feat(semantics): use a macro for suppressing UB warnings
picnixz Apr 10, 2025
8a2e2a6
Merge remote-tracking branch 'upstream/main' into feat/ubsan/explicit…
picnixz Apr 11, 2025
f6d6df3
fixup
picnixz Apr 11, 2025
2153507
fixup
picnixz Apr 11, 2025
efa7bdc
Update Include/methodobject.h
picnixz Apr 18, 2025
4bcff7f
address review
picnixz Apr 18, 2025
398e139
improve wording
picnixz Apr 18, 2025
8f567fa
Update Include/pyport.h
picnixz Apr 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
address review
  • Loading branch information
@picnixz
picnixz committed Apr 18, 2025
commit 4bcff7f00a01c074e042b4e7df086402f19edebf
2 changes: 1 addition & 1 deletion Include/methodobject.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ typedef PyObject *(*PyCMethod)(PyObject *, PyTypeObject *, PyObject *const *,
typedef PyCFunctionFast _PyCFunctionFast;
typedef PyCFunctionFastWithKeywords _PyCFunctionFastWithKeywords;

// Cast an function to the PyCFunction type to use it with PyMethodDef.
// Cast a function to the PyCFunction type to use it with PyMethodDef.
//
// This macro can be used to prevent compiler warnings if the first parameter
// uses a different pointer type than PyObject* (ex: METH_VARARGS and METH_O
Expand Down
8 changes: 8 additions & 0 deletions Include/pyport.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,14 @@
#endif
// Macro to use the more powerful/dangerous C-style cast even in C++.
#define _Py_CAST(type, expr) ((type)(expr))
// Cast a function to another function type T.
Comment thread
picnixz marked this conversation as resolved.
//
// The macro first casts the function to the "void func(void)" type
// to prevent compiler warnings.
//
// Note that using this cast only prevents the compiler from emitting
// warnings, but does not prevent an undefined behavior at runtime if
// the original function signature is not respected.
#define _Py_FUNC_CAST(T, func) _Py_CAST(T, _Py_CAST(void(*)(void), (func)))
Comment thread
picnixz marked this conversation as resolved.

// Static inline functions should use _Py_NULL rather than using directly NULL
Expand Down