Skip to content

gh-132097: use a macro for semantically casting function pointers #132406

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
picnixz merged 8 commits into from
Apr 18, 2025
+47 −31
Merged

gh-132097: use a macro for semantically casting function pointers #132406

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
09fb715
feat(semantics): use a macro for suppressing UB warnings
picnixz Apr 10, 2025
8a2e2a6
Merge remote-tracking branch 'upstream/main' into feat/ubsan/explicit…
picnixz Apr 11, 2025
f6d6df3
fixup
picnixz Apr 11, 2025
2153507
fixup
picnixz Apr 11, 2025
efa7bdc
Update Include/methodobject.h
picnixz Apr 18, 2025
4bcff7f
address review
picnixz Apr 18, 2025
398e139
improve wording
picnixz Apr 18, 2025
8f567fa
Update Include/pyport.h
picnixz Apr 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
improve wording
  • Loading branch information
@picnixz
picnixz committed Apr 18, 2025
commit 398e139d02bcb79a8372800f1f278b4a51110ced
5 changes: 3 additions & 2 deletions Include/methodobject.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,8 +51,9 @@ typedef PyCFunctionFastWithKeywords _PyCFunctionFastWithKeywords;
// (bpo-33012).
#define _PyCFunction_CAST(func) \
_Py_FUNC_CAST(PyCFunction, func)
// Other casts are given for semantic conveniences, allowing
// users to see whether a cast to suppress an undefined behavior is necessary.
// The macros below are given for semantic convenience, allowing users
// to see whether a cast to suppress an undefined behavior is necessary.
// Note: At runtime, the original function signature must be respected.
#define _PyCFunctionFast_CAST(func) \
_Py_FUNC_CAST(PyCFunctionFast, func)
#define _PyCFunctionWithKeywords_CAST(func) \
Expand Down
Loading