Skip to content

gh-69605: Add module autocomplete to PyREPL #129329

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pablogsal merged 18 commits into from
Apr 25, 2025
Merged

gh-69605: Add module autocomplete to PyREPL #129329

Changes from 1 commit
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
b3bcd67
Add module autocomplete to PyREPL
tomasr8 Jan 14, 2025
bcd3527
Add news entry
tomasr8 Jan 26, 2025
df3e8ec
Merge branch 'main' into completer
tomasr8 Jan 27, 2025
48ee6ad
Merge branch 'main' into completer
tomasr8 Feb 14, 2025
0917d24
Remove attribute completion, never import modules
tomasr8 Mar 3, 2025
589cf63
Add type annotations
tomasr8 Mar 8, 2025
62d0b55
fix some mypy issues
tomasr8 Mar 8, 2025
46ca249
Pass explicit None to find_spec
tomasr8 Mar 8, 2025
75e4b55
Merge branch 'main' into completer
tomasr8 Apr 17, 2025
3c13f86
Do not suggest modules which are not legal identifiers
tomasr8 Apr 17, 2025
8eb656f
Make the tests more robust
tomasr8 Apr 17, 2025
7a2fde0
Remove todo comment
tomasr8 Apr 19, 2025
5c11124
Move to a separate file and cache ModuleCompleter
tomasr8 Apr 19, 2025
10da15b
Avoid calling rstrip more than once
tomasr8 Apr 19, 2025
fd81999
Catch exceptions
tomasr8 Apr 19, 2025
8fba3d3
Fix tests
tomasr8 Apr 19, 2025
f4e290a
Every Reader has its own ModuleCompleter instance
tomasr8 Apr 19, 2025
602121d
tests: Only look for modules in the stdlib
tomasr8 Apr 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Make the tests more robust
  • Loading branch information
@tomasr8
tomasr8 committed Apr 17, 2025
commit 8eb656f7a1942c8652338447464e5914be01602d
12 changes: 11 additions & 1 deletion Lib/test/test_pyrepl/test_pyrepl.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
import tempfile
from unittest import TestCase, skipUnless, skipIf
from unittest.mock import patch
from test.support import force_not_colorized, make_clean_env
from test.support import force_not_colorized, make_clean_env, patch_list
from test.support import SHORT_TIMEOUT
from test.support.import_helper import import_module
from test.support.os_helper import unlink
Expand Down Expand Up @@ -904,7 +904,17 @@ def prepare_reader(self, events, namespace):
reader = ReadlineAlikeReader(console=console, config=config)
return reader

@patch_list(sys.meta_path)
def test_import_completions(self):
from importlib.machinery import BuiltinImporter
# Remove all importers except for the builtin one
# to prevent searching anything but the builtin modules.
# This makes the test more reliable in case there are
# other user packages/scripts on PYTHONPATH which can
# intefere with the completions.
sys.meta_path = [finder for finder in sys.meta_path
if isinstance(finder, BuiltinImporter)]

cases = (
("import path\t\n", "import pathlib"),
("import importlib.\t\tres\t\n", "import importlib.resources"),
Expand Down
Loading