Skip to content

gh-69605: Add module autocomplete to PyREPL #129329

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pablogsal merged 18 commits into from
Apr 25, 2025
Merged

gh-69605: Add module autocomplete to PyREPL #129329

Changes from 1 commit
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
b3bcd67
Add module autocomplete to PyREPL
tomasr8 Jan 14, 2025
bcd3527
Add news entry
tomasr8 Jan 26, 2025
df3e8ec
Merge branch 'main' into completer
tomasr8 Jan 27, 2025
48ee6ad
Merge branch 'main' into completer
tomasr8 Feb 14, 2025
0917d24
Remove attribute completion, never import modules
tomasr8 Mar 3, 2025
589cf63
Add type annotations
tomasr8 Mar 8, 2025
62d0b55
fix some mypy issues
tomasr8 Mar 8, 2025
46ca249
Pass explicit None to find_spec
tomasr8 Mar 8, 2025
75e4b55
Merge branch 'main' into completer
tomasr8 Apr 17, 2025
3c13f86
Do not suggest modules which are not legal identifiers
tomasr8 Apr 17, 2025
8eb656f
Make the tests more robust
tomasr8 Apr 17, 2025
7a2fde0
Remove todo comment
tomasr8 Apr 19, 2025
5c11124
Move to a separate file and cache ModuleCompleter
tomasr8 Apr 19, 2025
10da15b
Avoid calling rstrip more than once
tomasr8 Apr 19, 2025
fd81999
Catch exceptions
tomasr8 Apr 19, 2025
8fba3d3
Fix tests
tomasr8 Apr 19, 2025
f4e290a
Every Reader has its own ModuleCompleter instance
tomasr8 Apr 19, 2025
602121d
tests: Only look for modules in the stdlib
tomasr8 Apr 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Remove todo comment
  • Loading branch information
@tomasr8
tomasr8 committed Apr 19, 2025
commit 7a2fde06e0b5cb9310b1947e0f449b2e22a0d39d
3 changes: 2 additions & 1 deletion Lib/_pyrepl/readline.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -170,7 +170,8 @@ def get_completions(self, stem: str) -> list[str]:
return result

def get_module_completions(self) -> list[str]:
completer = ModuleCompleter(namespace={'__package__': '_pyrepl'}) # TODO: namespace?
# Inside pyrepl, __package__ is set to '_pyrepl'
completer = ModuleCompleter(namespace={'__package__': '_pyrepl'})
line = self.get_line()
return completer.get_completions(line)
Copy link
Copy Markdown
Member

@pablogsal pablogsal Apr 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can this raise? What do we want to do if any of the pkgutil raises for any reason?

Copy link
Copy Markdown
Member Author

@tomasr8 tomasr8 Apr 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It shouldn't unless iter_modules or find_spec raise. Since those can call code from user-supplied finders, they can raise an arbitrary exception. I could add a simple except Exception block and simply return no completions if that happens. To the user it would look like no completions are available rather than outright crashing the repl.

Copy link
Copy Markdown
Member Author

@tomasr8 tomasr8 Apr 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added in fd81999


Expand Down