Skip to content

gh-127146: skip Emscripten tests with pending fixes #128549

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
freakboy3742 merged 5 commits into from
Jan 6, 2025
Merged

gh-127146: skip Emscripten tests with pending fixes #128549

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
7e77e68
gh-127146: skip some tests that are fixed on the main branch of Emscr…
hoodmane Jan 6, 2025
a8bbec5
Skip two more tests which are fixed by a pending Emscripten PR
hoodmane Jan 6, 2025
b1d36b1
Revert "Skip two more tests which are fixed by a pending Emscripten PR"
hoodmane Jan 6, 2025
d03adfb
Add reference to fix for pipe i/o
hoodmane Jan 6, 2025
0e7f1f3
Add reference to fix for setting time to 0
hoodmane Jan 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Add reference to fix for pipe i/o
  • Loading branch information
@hoodmane
hoodmane committed Jan 6, 2025
commit d03adfbc87131c4b90780c66aca40cfd5bad89f7
1 change: 1 addition & 0 deletions Lib/test/test_io.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3933,6 +3933,7 @@ def test_issue35928(self):
self.assertEqual(res + f.readline(), 'foo\nbar\n')

@unittest.skipUnless(hasattr(os, "pipe"), "requires os.pipe()")
@unittest.skipIf(support.is_emscripten, "Would be fixed by emscripten-core/emscripten#23306")
def test_read_non_blocking(self):
import os
r, w = os.pipe()
Expand Down