Skip to content

gh-127146: skip Emscripten tests with pending fixes #128549

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
freakboy3742 merged 5 commits into from
Jan 6, 2025
Merged

gh-127146: skip Emscripten tests with pending fixes #128549

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
7e77e68
gh-127146: skip some tests that are fixed on the main branch of Emscr…
hoodmane Jan 6, 2025
a8bbec5
Skip two more tests which are fixed by a pending Emscripten PR
hoodmane Jan 6, 2025
b1d36b1
Revert "Skip two more tests which are fixed by a pending Emscripten PR"
hoodmane Jan 6, 2025
d03adfb
Add reference to fix for pipe i/o
hoodmane Jan 6, 2025
0e7f1f3
Add reference to fix for setting time to 0
hoodmane Jan 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Revert "Skip two more tests which are fixed by a pending Emscripten PR" 
This reverts commit a8bbec5.
  • Loading branch information
@hoodmane
hoodmane committed Jan 6, 2025
commit b1d36b1d1016c3d527d07e16dc112448b1f9a725
1 change: 0 additions & 1 deletion Lib/test/test_io.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3933,7 +3933,6 @@ def test_issue35928(self):
self.assertEqual(res + f.readline(), 'foo\nbar\n')

@unittest.skipUnless(hasattr(os, "pipe"), "requires os.pipe()")
@unittest.skipIf(support.is_emscripten, "Would be fixed by emscripten-core/emscripten#23058")
def test_read_non_blocking(self):
import os
r, w = os.pipe()
Expand Down
4 changes: 1 addition & 3 deletions Lib/test/test_zipfile/test_core.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,8 +22,7 @@
from test.support import script_helper
from test.support import (
findfile, requires_zlib, requires_bz2, requires_lzma,
captured_stdout, captured_stderr, requires_subprocess,
is_emscripten
captured_stdout, captured_stderr, requires_subprocess
)
from test.support.os_helper import (
TESTFN, unlink, rmtree, temp_dir, temp_cwd, fd_count, FakePath
Expand Down Expand Up @@ -623,7 +622,6 @@ def test_write_to_readonly(self):
with self.assertRaises(ValueError):
zipfp.open(TESTFN, mode='w')

@unittest.skipIf(support.is_emscripten, "Would be fixed by emscripten-core/emscripten#23058")
def test_add_file_before_1980(self):
# Set atime and mtime to 1970-01-01
os.utime(TESTFN, (0, 0))
Expand Down