Skip to content

gh-126018: Avoid aborting due to unnecessary assert in sys.audit #126020

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JelleZijlstra merged 7 commits into from
Oct 27, 2024
Merged

gh-126018: Avoid aborting due to unnecessary assert in sys.audit #126020

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
ba8ac4d
Remove an assert that sys.audit's args[0] passes PyUnicode_Check.
devdanzin Oct 26, 2024
620f682
Test that passing a non-string to sys.audit doesn't trigger an assert…
devdanzin Oct 26, 2024
b775f5d
📜🤖 Added by blurb_it.
blurb-it[bot] Oct 26, 2024
6234c5d
Apply suggestions from code review
devdanzin Oct 26, 2024
a6edd2c
Apply suggestions from code review by @Eclips4.
devdanzin Oct 27, 2024
57cc87c
Fail test_assert_unicode if no exception is raised by sys.audit(9) (t…
devdanzin Oct 27, 2024
c42c4d6
Apply review suggestion for better description of issue in NEWS.
devdanzin Oct 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Apply suggestions from code review by @Eclips4.
  • Loading branch information
@devdanzin
devdanzin committed Oct 27, 2024
commit a6edd2ca507a14f1d908ea00fb17f7dad606ccc8
1 change: 1 addition & 0 deletions Lib/test/test_audit.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -308,6 +308,7 @@ def test_winapi_createnamedpipe(self):
self.assertEqual(actual, expected)

def test_assert_unicode(self):
# See gh-126018
returncode, _, stderr = self.run_python("test_assert_unicode")
if returncode:
self.fail(stderr)
Expand Down