Skip to content

gh-126018: Avoid aborting due to unnecessary assert in sys.audit #126020

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JelleZijlstra merged 7 commits into from
Oct 27, 2024
Merged

gh-126018: Avoid aborting due to unnecessary assert in sys.audit #126020

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
ba8ac4d
Remove an assert that sys.audit's args[0] passes PyUnicode_Check.
devdanzin Oct 26, 2024
620f682
Test that passing a non-string to sys.audit doesn't trigger an assert…
devdanzin Oct 26, 2024
b775f5d
📜🤖 Added by blurb_it.
blurb-it[bot] Oct 26, 2024
6234c5d
Apply suggestions from code review
devdanzin Oct 26, 2024
a6edd2c
Apply suggestions from code review by @Eclips4.
devdanzin Oct 27, 2024
57cc87c
Fail test_assert_unicode if no exception is raised by sys.audit(9) (t…
devdanzin Oct 27, 2024
c42c4d6
Apply review suggestion for better description of issue in NEWS.
devdanzin Oct 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Test that passing a non-string to sys.audit doesn't trigger an assert… 
… in debug builds.
  • Loading branch information
@devdanzin
devdanzin committed Oct 26, 2024
commit 620f682a980f9b5be3ae77dd645e48d172c85e02
9 changes: 9 additions & 0 deletions Lib/test/audit-tests.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -567,6 +567,15 @@ def hook(event, args):
_winapi.CreateNamedPipe(pipe_name, _winapi.PIPE_ACCESS_DUPLEX, 8, 2, 0, 0, 0, 0)


def test_assert_unicode():
import sys
sys.addaudithook(lambda *args: None)
try:
sys.audit(9)
except:
pass
Comment thread
devdanzin marked this conversation as resolved.
Comment thread
devdanzin marked this conversation as resolved.


if __name__ == "__main__":
from test.support import suppress_msvcrt_asserts

Expand Down
6 changes: 6 additions & 0 deletions Lib/test/test_audit.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -307,5 +307,11 @@ def test_winapi_createnamedpipe(self):

self.assertEqual(actual, expected)

def test_assert_unicode(self):
returncode, events, stderr = self.run_python("test_assert_unicode")
Comment thread
devdanzin marked this conversation as resolved.
Outdated
Comment thread
picnixz marked this conversation as resolved.
Outdated
if returncode:
self.fail(stderr)


if __name__ == "__main__":
unittest.main()