Skip to content

gh-118331: Don't raise an error if tuple allocation fails when clearing weakrefs #118338

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
colesbury merged 6 commits into from
Apr 29, 2024
Merged

gh-118331: Don't raise an error if tuple allocation fails when clearing weakrefs #118338

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
195a7e5
Don't raise an error if tuple allocation fails when clearing weakrefs
mpage Apr 26, 2024
99e3f85
Fix test
mpage Apr 26, 2024
632087c
Make test more robust to future changes
mpage Apr 27, 2024
7ba419d
Don't pass object to `PyErr_WriteUnraisable`
mpage Apr 27, 2024
15c85d4
Don't chain exceptions
mpage Apr 29, 2024
728a297
Merge branch 'main' into gh-118331-wr-no-mem
mpage Apr 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix test
  • Loading branch information
@mpage
mpage committed Apr 26, 2024
commit 99e3f854df936e98665a99f83eb36816f3be4a9c
2 changes: 1 addition & 1 deletion Lib/test/test_weakref.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1032,7 +1032,7 @@ def callback(obj):
_testcapi.set_nomemory(0)
del obj
""").strip()
res = script_helper.assert_python_failure("-c", code)
res = script_helper.assert_python_ok("-c", code)
stderr = res.err.decode("ascii", "backslashreplace")
self.assertNotRegex(stderr, "_Py_Dealloc: Deallocator of type")

Expand Down