Skip to content

gh-69893: Add the close() method for xml.etree.ElementTree.iterparse() iterator #114534

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
serhiy-storchaka merged 3 commits into from
Feb 4, 2024
Merged

gh-69893: Add the close() method for xml.etree.ElementTree.iterparse() iterator #114534

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4a2d1d8
gh-69893: Add the close() method for xml.etree.ElementTree.iterparse(…
serhiy-storchaka Jul 2, 2021
3f5b365
Remove unnecessary `gc_collect()`.
serhiy-storchaka Jan 24, 2024
e527b59
Update Lib/xml/etree/ElementTree.py
serhiy-storchaka Jan 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Update Lib/xml/etree/ElementTree.py
  • Loading branch information
@serhiy-storchaka
serhiy-storchaka authored Jan 26, 2024
commit e527b59a5b1b3e0cf6e1ee99a445072c7e5a0206
1 change: 1 addition & 0 deletions Lib/xml/etree/ElementTree.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1258,6 +1258,7 @@ def close(self):

def __del__(self):
# TODO: Emit a ResourceWarning if it was not explicitly closed.
Copy link
Copy Markdown
Member

@hugovk hugovk Jan 26, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any plans for when this TODO will be done? They can end up languishing for decades :)

Copy link
Copy Markdown
Member Author

@serhiy-storchaka serhiy-storchaka Jan 26, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When all maintained Python versions have the close() method, so you can call it without checking the version.

Copy link
Copy Markdown
Member

@hugovk hugovk Jan 26, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe update the TODO to mention this, so when someone sees it they know whether they can do the TODO or wait a bit longer?

Anyway, I'll approve this.

Comment thread
serhiy-storchaka marked this conversation as resolved.
# (When the close() method will be supported in all maintained Python versions.)
if close_source:
source.close()

Expand Down