Skip to content

gh-69893: Add the close() method for xml.etree.ElementTree.iterparse() iterator #114534

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
serhiy-storchaka merged 3 commits into from
Feb 4, 2024
Merged

gh-69893: Add the close() method for xml.etree.ElementTree.iterparse() iterator #114534

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4a2d1d8
gh-69893: Add the close() method for xml.etree.ElementTree.iterparse(…
serhiy-storchaka Jul 2, 2021
3f5b365
Remove unnecessary `gc_collect()`.
serhiy-storchaka Jan 24, 2024
e527b59
Update Lib/xml/etree/ElementTree.py
serhiy-storchaka Jan 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Remove unnecessary gc_collect().
  • Loading branch information
@serhiy-storchaka
serhiy-storchaka committed Jan 24, 2024
commit 3f5b3653dcc41502d20d73edee78328260b64862
6 changes: 0 additions & 6 deletions Lib/test/test_xml_etree.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -619,7 +619,6 @@ def test_iterparse(self):
iterparse(SIMPLE_XMLFILE, events)
self.assertEqual(str(cm.exception), "unknown event 'bogus'")
del cm
gc_collect()

source = io.BytesIO(
b"<?xml version='1.0' encoding='iso-8859-1'?>\n"
Expand Down Expand Up @@ -653,34 +652,29 @@ def test_iterparse(self):
self.assertEqual(str(cm.exception),
'junk after document element: line 1, column 12')
del cm, it
gc_collect()

# Not exhausting the iterator still closes the resource (bpo-43292)
with warnings_helper.check_no_resource_warning(self):
it = iterparse(SIMPLE_XMLFILE)
del it
gc_collect()

with warnings_helper.check_no_resource_warning(self):
it = iterparse(SIMPLE_XMLFILE)
it.close()
del it
gc_collect()

with warnings_helper.check_no_resource_warning(self):
it = iterparse(SIMPLE_XMLFILE)
action, elem = next(it)
self.assertEqual((action, elem.tag), ('end', 'element'))
del it, elem
gc_collect()

with warnings_helper.check_no_resource_warning(self):
it = iterparse(SIMPLE_XMLFILE)
action, elem = next(it)
it.close()
self.assertEqual((action, elem.tag), ('end', 'element'))
del it, elem
gc_collect()

with self.assertRaises(FileNotFoundError):
iterparse("nonexistent")
Expand Down