Skip to content

bpo-35491: Enhance multiprocessing.BaseProcess.__repr__() #11138

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vstinner merged 1 commit into from
Dec 14, 2018
Merged

bpo-35491: Enhance multiprocessing.BaseProcess.__repr__() #11138

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions Doc/library/multiprocessing.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -626,14 +626,14 @@ The :mod:`multiprocessing` package mostly replicates the API of the
>>> import multiprocessing, time, signal
>>> p = multiprocessing.Process(target=time.sleep, args=(1000,))
>>> print(p, p.is_alive())
<Process(..., initial)> False
<Process ... initial> False
>>> p.start()
>>> print(p, p.is_alive())
<Process(..., started)> True
<Process ... started> True
>>> p.terminate()
>>> time.sleep(0.1)
>>> print(p, p.is_alive())
<Process(..., stopped[SIGTERM])> False
<Process ... stopped exitcode=-SIGTERM> False
>>> p.exitcode == -signal.SIGTERM
True

Expand Down
27 changes: 16 additions & 11 deletions Lib/multiprocessing/process.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -248,6 +248,7 @@ def sentinel(self):
raise ValueError("process not started") from None

def __repr__(self):
exitcode = None
if self is _current_process:
status = 'started'
elif self._closed:
Expand All @@ -257,19 +258,23 @@ def __repr__(self):
elif self._popen is None:
status = 'initial'
else:
if self._popen.poll() is not None:
status = self.exitcode
else:
status = 'started'

if type(status) is int:
if status == 0:
exitcode = self._popen.poll()
if exitcode is not None:
status = 'stopped'
else:
status = 'stopped[%s]' % _exitcode_to_name.get(status, status)
status = 'started'

return '<%s(%s, %s%s)>' % (type(self).__name__, self._name,
status, self.daemon and ' daemon' or '')
info = [type(self).__name__, 'name=%r' % self._name]
if self._popen is not None:
info.append('pid=%s' % self._popen.pid)
info.append('parent=%s' % self._parent_pid)
info.append(status)
if exitcode is not None:
exitcode = _exitcode_to_name.get(exitcode, exitcode)
info.append('exitcode=%s' % exitcode)
if self.daemon:
info.append('daemon')
return '<%s>' % ' '.join(info)

##

Expand Down Expand Up @@ -373,7 +378,7 @@ def close(self):

for name, signum in list(signal.__dict__.items()):
if name[:3]=='SIG' and '_' not in name:
_exitcode_to_name[-signum] = name
_exitcode_to_name[-signum] = f'-{name}'

# For debug and leak testing
_dangling = WeakSet()
4 changes: 4 additions & 0 deletions Misc/NEWS.d/next/Library/2018-12-14-12-12-15.bpo-35491.jHsNOU.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
:mod:`multiprocessing`: Add ``Pool.__repr__()`` and enhance
``BaseProcess.__repr__()`` (add pid and parent pid) to ease debugging. Pool
state constant values are now strings instead of integers, for example ``RUN``
value becomes ``'RUN'`` instead of ``0``.