Skip to content

bpo-35491: Enhance multiprocessing.BaseProcess.__repr__()#11138

Merged
vstinner merged 1 commit into
python:masterfrom
vstinner:mp_process_repr
Dec 14, 2018
Merged

bpo-35491: Enhance multiprocessing.BaseProcess.__repr__()#11138
vstinner merged 1 commit into
python:masterfrom
vstinner:mp_process_repr

Conversation

@vstinner
Copy link
Copy Markdown
Member

@vstinner vstinner commented Dec 13, 2018

Add the pid to multiprocessing.BaseProcess.repr(). Avoid also to
call _popen.poll() twice.

Example:
<ForkProcess(ForkPoolWorker-1, started daemon)>
becomes:
<ForkProcess(ForkPoolWorker-1, started[pid=28444] daemon)>

https://bugs.python.org/issue35491

@serhiy-storchaka
Copy link
Copy Markdown
Member

Why "skip issue"?

@vstinner
Copy link
Copy Markdown
Member Author

Why "skip issue"?

I decided to not open an issue to modify repr(). I consider repr() output is not part of the Python API.

@vstinner vstinner changed the title Enhance multiprocessing.BaseProcess.__repr__() bpo-35491: Enhance multiprocessing.BaseProcess.__repr__() Dec 14, 2018
@vstinner
Copy link
Copy Markdown
Member Author

Why "skip issue"?

I'm not sure if you request to create an issue or not. In case of doubt, I created https://bugs.python.org/issue35491

* Add the pid and parent pid to multiprocessing.BaseProcess.__repr__().
* Add negative sign (ex: "-SIGTERM") for exitcode (process killed
  by a signal)
* Avoid also to call _popen.poll() twice.

Example:
  <ForkProcess(ForkPoolWorker-1, started daemon)>
becomes:
  <ForkProcess name='ForkPoolWorker-1' pid=12449 parent=12448 started daemon>

Example:
  <ForkProcess(ForkPoolWorker-1, stopped[SIGTERM] daemon)>
becomes:
  <ForkProcess name='ForkPoolWorker-1' pid=12960 parent=12959 stopped exitcode=-SIGTERM daemon>
@vstinner
Copy link
Copy Markdown
Member Author

I added a NEWS entry.

@vstinner vstinner merged commit 7acd50a into python:master Dec 14, 2018
@vstinner vstinner deleted the mp_process_repr branch December 14, 2018 11:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants