Skip to content

fix: forward tenth argument in runEffectFn10 #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Unisay merged 2 commits into from
Jun 14, 2026
Merged

fix: forward tenth argument in runEffectFn10 #2

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
13ebb30
fix: forward tenth argument in runEffectFn10
Unisay Jun 14, 2026
04eb45a
test: regression guard for runEffectFn10 forwarding all ten args
Unisay Jun 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions scripts/test
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
#!/usr/bin/env bash
set -euo pipefail

echo "Running regression tests..."

lua test/regression/uncurried.lua
2 changes: 1 addition & 1 deletion src/Effect/Uncurried.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -196,7 +196,7 @@ return {
return function(i)
return function(j)
return function()
return fn(a, b, c, d, e, f, g, h, i)
return fn(a, b, c, d, e, f, g, h, i, j)
end
end
end
Expand Down
25 changes: 25 additions & 0 deletions test/regression/uncurried.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,25 @@
-- Regression guard: runEffectFn10 must forward all ten arguments.
--
-- The FFI bound ten curried parameters a..j but called the underlying
-- function with only nine (a..i), silently dropping j. This loads the
-- FFI table directly and checks that every argument reaches `fn`.

local M = assert(dofile("src/Effect/Uncurried.lua"))

local seen
local recorder = function(...)
seen = { ... }
return nil
end

-- runEffectFn10(fn)(a)(b)...(j)() applies fn to all ten arguments.
M.runEffectFn10(recorder)(1)(2)(3)(4)(5)(6)(7)(8)(9)(10)()

assert(seen ~= nil, "fn was never called")
assert(#seen == 10, "expected 10 forwarded arguments, got " .. #seen)
for k = 1, 10 do
assert(seen[k] == k,
"argument #" .. k .. " not forwarded (got " .. tostring(seen[k]) .. ")")
end

print("OK runEffectFn10 forwards all ten arguments")