fix: forward tenth argument in runEffectFn10#2
Merged
Conversation
runEffectFn10 bound ten curried parameters a..j but only forwarded nine to the underlying function, silently dropping j (luacheck: unused argument j). Forward j so all ten declared arguments reach fn. Closes #1
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1
Forward the tenth argument in
runEffectFn10. It bound ten curried parametersathroughjbut only forwarded nine to the underlying function, callingfn(a, b, c, d, e, f, g, h, i)and silently droppingj. luacheck flagged this asunused argument jatsrc/Effect/Uncurried.lua:197.The fix forwards
j:return fn(a, b, c, d, e, f, g, h, i, j). One-token change confined tosrc/.Audited the whole
mkEffectFnN/runEffectFnNfamily:runEffectFn10was the only offender. After the fix,luacheck --quiet --std min src/Effect/Uncurried.luais clean andnix develop -c ./scripts/buildsucceeds.