Conversation
Member
|
👍 |
Contributor
Author
|
I think this is ready to review. /cc @natefaubion |
Contributor
|
We also needed the mtl instances for ExceptT. We had them for ErrorT, but not ExceptT. |
Contributor
Author
|
Ah good point, thanks. |
Contributor
Author
|
We actually should release this together with 0.7.4 since neither's CI build will pass without the other. |
Contributor
Author
|
I've added module exports too. This is ready for review again. |
Member
|
I'll probably have to review tomorrow morning now, just trying to solve something for SD before bed. Pretty excited for these (and the accompanying typechecker) updates 😄 |
Member
|
Looks great! I made a PR #50 targeting this branch that further simplifies some of the contexts that can now depend on superclass implications. |
Further simplify some contexts for the no-t1 branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MonadRec ExceptTinstance (and others?)mtlinstances forExceptT