Skip to content

Redux: Qualify types as necessary in errors and warnings #4409

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
MonoidMusician wants to merge 12 commits into
base: master
Choose a base branch
from
Open

Redux: Qualify types as necessary in errors and warnings #4409

Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
2d040d6
wip
hdgarrood May 22, 2022
ddf09ec
Exhaustiveness to compile
MonoidMusician Oct 24, 2022
1a8bf47
Commit test output
MonoidMusician Oct 24, 2022
cd75a8a
Merge remote-tracking branch 'origin/master' into mm/diagnostic-quali…
MonoidMusician Oct 24, 2022
ab63110
Fix merge
MonoidMusician Oct 24, 2022
1471122
Add tests for conflicting types with same name
MonoidMusician Oct 27, 2022
2b431ff
Work on requalifying typeclasses in error messages
MonoidMusician Oct 27, 2022
53a0fe4
Commit new test output
MonoidMusician Oct 27, 2022
d483513
Move requalifyTypesInErrors from Make.hs to Requalify.hs
MonoidMusician Oct 27, 2022
3d05987
Quantified shadowing test
MonoidMusician Oct 27, 2022
e1eb50d
Add specific error for constructors that could not be unified
MonoidMusician Oct 27, 2022
8da7e96
Commit test output
MonoidMusician Oct 27, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Exhaustiveness to compile
  • Loading branch information
@MonoidMusician
MonoidMusician committed Oct 24, 2022
commit ddf09ec1b97fe0cba87aa1b5374f94827217de78
2 changes: 2 additions & 0 deletions src/Language/PureScript/Errors.hs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -482,6 +482,7 @@ onTypesInErrorMessageM f (ErrorMessage hints simple) = ErrorMessage <$> traverse
gSimple (MissingKindDeclaration sig nm ty) = MissingKindDeclaration sig nm <$> f ty
gSimple (CannotGeneralizeRecursiveFunction nm ty) = CannotGeneralizeRecursiveFunction nm <$> f ty
gSimple (InvalidCoercibleInstanceDeclaration tys) = InvalidCoercibleInstanceDeclaration <$> traverse f tys
gSimple other = pure other

gHint (ErrorInSubsumption t1 t2) = ErrorInSubsumption <$> f t1 <*> f t2
gHint (ErrorUnifyingTypes t1 t2) = ErrorUnifyingTypes <$> f t1 <*> f t2
Expand All @@ -491,6 +492,7 @@ onTypesInErrorMessageM f (ErrorMessage hints simple) = ErrorMessage <$> traverse
gHint (ErrorInApplication e1 t1 e2) = ErrorInApplication e1 <$> f t1 <*> pure e2
gHint (ErrorInInstance cl ts) = ErrorInInstance cl <$> traverse f ts
gHint (ErrorSolvingConstraint con) = ErrorSolvingConstraint <$> overConstraintArgs (traverse f) con
gHint other = pure other

errorDocUri :: ErrorMessage -> Text
errorDocUri e = "https://github.com/purescript/documentation/blob/master/errors/" <> errorCode e <> ".md"
Expand Down