Skip to content

Redux: Qualify types as necessary in errors and warnings #4409

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
MonoidMusician wants to merge 12 commits into
base: master
Choose a base branch
from
Open

Redux: Qualify types as necessary in errors and warnings #4409

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
2d040d6
wip
hdgarrood May 22, 2022
ddf09ec
Exhaustiveness to compile
MonoidMusician Oct 24, 2022
1a8bf47
Commit test output
MonoidMusician Oct 24, 2022
cd75a8a
Merge remote-tracking branch 'origin/master' into mm/diagnostic-quali…
MonoidMusician Oct 24, 2022
ab63110
Fix merge
MonoidMusician Oct 24, 2022
1471122
Add tests for conflicting types with same name
MonoidMusician Oct 27, 2022
2b431ff
Work on requalifying typeclasses in error messages
MonoidMusician Oct 27, 2022
53a0fe4
Commit new test output
MonoidMusician Oct 27, 2022
d483513
Move requalifyTypesInErrors from Make.hs to Requalify.hs
MonoidMusician Oct 27, 2022
3d05987
Quantified shadowing test
MonoidMusician Oct 27, 2022
e1eb50d
Add specific error for constructors that could not be unified
MonoidMusician Oct 27, 2022
8da7e96
Commit test output
MonoidMusician Oct 27, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Add tests for conflicting types with same name
  • Loading branch information
@MonoidMusician
MonoidMusician committed Oct 27, 2022
commit 14711224b76361f82c8eff79f71d9b56997f139d
24 changes: 24 additions & 0 deletions tests/purs/failing/QualifiedErrorsUnification.out
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,24 @@
Error found:
in module Main
at tests/purs/failing/QualifiedErrorsUnification.purs:9:15 - 9:18 (line 9, column 15 - line 9, column 18)

Could not match type
 
 Data.List.Lazy.Types.List
 
with type
 
 List
 

while trying to match type List t0
with type List Unit
while checking that expression nil
has type List Unit
in value declaration wrongModule

where t0 is an unknown type

See https://github.com/purescript/documentation/blob/master/errors/TypesDoNotUnify.md for more information,
or to contribute content related to this error.

9 changes: 9 additions & 0 deletions tests/purs/failing/QualifiedErrorsUnification.purs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
-- @shouldFailWith TypesDoNotUnify
module Main where

import Prelude (Unit)
import Data.List.Lazy (nil)
import Data.List.Types (List)

wrongModule :: List Unit
wrongModule = nil
24 changes: 24 additions & 0 deletions tests/purs/failing/QualifiedErrorsUnificationLocal.out
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,24 @@
Error found:
in module Main
at tests/purs/failing/QualifiedErrorsUnificationLocal.purs:10:15 - 10:18 (line 10, column 15 - line 10, column 18)

Could not match type
 
 Data.List.Lazy.Types.List
 
with type
 
 List
 

while trying to match type List t0
with type List Unit
while checking that expression nil
has type List Unit
in value declaration wrongModule

where t0 is an unknown type

See https://github.com/purescript/documentation/blob/master/errors/TypesDoNotUnify.md for more information,
or to contribute content related to this error.

10 changes: 10 additions & 0 deletions tests/purs/failing/QualifiedErrorsUnificationLocal.purs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
-- @shouldFailWith TypesDoNotUnify
module Main where

import Prelude (Unit)
import Data.List.Lazy (nil)

data List (a :: Type)

wrongModule :: List Unit
wrongModule = nil
24 changes: 24 additions & 0 deletions tests/purs/failing/QualifiedErrorsUnificationReexport.out
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,24 @@
Error found:
in module Main
at tests/purs/failing/QualifiedErrorsUnificationReexport.purs:9:15 - 9:18 (line 9, column 15 - line 9, column 18)

Could not match type
 
 Data.List.Lazy.Types.List
 
with type
 
 Data.List.Types.List
 

while trying to match type List t0
with type List Unit
while checking that expression nil
has type List Unit
in value declaration wrongModule

where t0 is an unknown type

See https://github.com/purescript/documentation/blob/master/errors/TypesDoNotUnify.md for more information,
or to contribute content related to this error.

9 changes: 9 additions & 0 deletions tests/purs/failing/QualifiedErrorsUnificationReexport.purs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
-- @shouldFailWith TypesDoNotUnify
module Main where

import Prelude (Unit)
import Data.List.Lazy (nil)
import Data.List (List)

wrongModule :: List Unit
wrongModule = nil