Skip to content

Restrict base for GHC < 8.4.1#3294

Merged
kritzcreek merged 1 commit into
purescript:masterfrom
parsonsmatt:matt/base-restriction
Apr 27, 2018
Merged

Restrict base for GHC < 8.4.1#3294
kritzcreek merged 1 commit into
purescript:masterfrom
parsonsmatt:matt/base-restriction

Conversation

@parsonsmatt

Copy link
Copy Markdown
Contributor

This PR addresses #3284 with a stop-gap measure, explicitly expressing the upper bound on base that PureScript currently has.

When PureScript officially supports 8.4.1, this can be dropped.

@kritzcreek

Copy link
Copy Markdown
Member

Okay, so I tried to bump to latest Stackage nightly and build from there, but the ecosystem still needs to catch up with 8.4.1, so I'll merge this PR and we can tackle upgrading after releasing 0.12. Thanks!

@kritzcreek kritzcreek merged commit 27ad08a into purescript:master Apr 27, 2018
@ilovezfs

Copy link
Copy Markdown
Contributor

@kritzcreek now that 0.12.0 is out, is there any update on 8.4.x support?

@kritzcreek

Copy link
Copy Markdown
Member

The last time I tried libraries we depended on still didn't build with 8.4.1, but I can give it another try today.

@ilovezfs

Copy link
Copy Markdown
Contributor

Thanks! Also note that the current version is now 8.4.3 :)

@kritzcreek

Copy link
Copy Markdown
Member

I'm going for 8.4.2 since it's the current nightly version. Shouldn't be a big deal to update that to 8.4.3 though.

@ilovezfs

Copy link
Copy Markdown
Contributor

Yeah I retested the builds of everything in Homebrew that was using 8.4.2 when we upgraded to 8.4.3 and nothing broke so I wouldn't anticipate a problem.

@kritzcreek

Copy link
Copy Markdown
Member

see #3372, just one library missing :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants