Fix compilation with ghc-8.4#3287
Closed
brandonhamilton wants to merge 2 commits into
Closed
Conversation
Contributor
|
Sorry, but I’m 👎 on supporting more than one series of GHC at once if it requires any extra work at all, and I’m definitely 👎 on CPP. |
Contributor
Author
|
No problem :) Happy to close this for now. |
Contributor
|
Is a there a reason not to move to 8.4.x for master without CPP? We'd like to retire GHC 8.2.x in Homebrew as soon as possible. |
Contributor
|
Yes, the ecosystem hasn't quite caught up yet. See #3294 (comment) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Compatibility with the new Semigroup as superclass of Monoid.
The changes were made so that the code still compiles with the current
ghc-8.2.2compiler (stackagelts-10.3), as well as the latestghc-8.4.1(tested with stackagenightly-2018-03-23).Resolves #3284