Use strict writers to avoid leaking memory#1410
Merged
Merged
Conversation
Member
Author
|
Alright, culprit 2 was 6d3a777, so this probably is as good as it gets as it makes that We're still using 10x as much as memory as the pre-warnings version though, I'm sure there's room for some other improvements. Maybe some use of |
Contributor
|
👍 Amazing. |
garyb
added a commit
that referenced
this pull request
Aug 23, 2015
Use strict writers to avoid leaking memory
|
👍 👍 🎆 💥 🎆 👍 👍 |
|
10x down, 10x more to go. 😉 |
Member
Author
|
I hope so! 😉 I think SlamData's Travis should start working again at least, even with just this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #1297, there may be a round 2 yet.
An unscientific test of compiling
SlamDatafrom scratch and eyeballing the process monitor with these changes applied reduces the peak memory usage from ~12.5gb to ~2.5gb. Also compilation time is reduced from ~68s to ~37s.💥💥💥