Skip to content

[3.9.x] Markdown: Don't let Liquid objects interrupt paragraphs - #20086

Closed
lazerg wants to merge 4 commits into
prettier:v3.9.xfrom
lazerg:fix/issue-20083-liquid-object-interrupt-v3.9.x
Closed

[3.9.x] Markdown: Don't let Liquid objects interrupt paragraphs#20086
lazerg wants to merge 4 commits into
prettier:v3.9.xfrom
lazerg:fix/issue-20083-liquid-object-interrupt-v3.9.x

Conversation

@lazerg

@lazerg lazerg commented Sep 16, 2026 •
edited by fisker
Loading

Copy link
Copy Markdown
Contributor

Description

Backport #20085
Fixes #20083

Checklist

  • I've added tests to confirm my change works.
  • (If changing the API or CLI) I've documented the changes I've made (in the docs/ directory).
  • (If the change is user-facing) I've added my changes to changelog_unreleased/*/XXXX.md file following changelog_unreleased/TEMPLATE.md.
  • I've read the contributing guidelines.
  • I did not use AI to generate this PR.
  • (If the above is not checked) I have reviewed the AI-generated content before submitting.

@netlify

netlify Bot commented Sep 16, 2026 •
edited
Loading

Copy link
Copy Markdown

✅ Deploy Preview for prettier ready!

Name Link
🔨 Latest commit af6a412
🔍 Latest deploy log https://app.netlify.com/projects/prettier/deploys/6aac5112367a5d0008ce968f
😎 Deploy Preview https://deploy-preview-20086--prettier.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
🤖 Make changes Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

@pkg-pr-new

pkg-pr-new Bot commented Sep 16, 2026 •
edited
Loading

Copy link
Copy Markdown

Open in StackBlitz

yarn add https://pkg.pr.new/@prettier/plugin-hermes@20086.tgz

yarn add https://pkg.pr.new/@prettier/plugin-oxc@20086.tgz

yarn add https://pkg.pr.new/@prettier/plugin-yuku@20086.tgz

yarn add https://pkg.pr.new/prettier@20086.tgz

commit: af6a412

@lazerg lazerg mentioned this pull request Sep 16, 2026
Closed
4 of 6 tasks
fisker
fisker reviewed Sep 16, 2026
View reviewed changes
Comment thread changelog_unreleased/markdown/20085.md
@lazerg lazerg mentioned this pull request Sep 16, 2026
Merged
3 of 6 tasks
@github-actions github-actions Bot mentioned this pull request Sep 16, 2026
Open
fisker added a commit that referenced this pull request Sep 17, 2026
@fisker
One more test from #20086
59c2de5
fisker
fisker reviewed Sep 17, 2026
View reviewed changes
Comment thread tests/format/markdown/liquid/__snapshots__/format.test.js.snap
Comment on lines +555 to +563
abcdefg abcdefg

{% comment %} here is comment {% endcomment %}

---

abcdefg abcdefg

{% comment %} here is comment {% endcomment %}

@fisker fisker Sep 17, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These two cases doesn't look good, #20087 (comment)

I'll merge #20087 instead, thanks anyway!

@fisker

fisker commented Sep 17, 2026

Copy link
Copy Markdown
Member

Close in favor of #20087

@fisker fisker closed this Sep 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fisker fisker fisker left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@lazerg @fisker