Repository navigation
Conversation
✅ Deploy Preview for prettier ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify project configuration. |
commit: |
✅ Deploy Preview for prettier ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify project configuration. |
Member
|
@lazerg Thanks for fixing this, would you mind fixing this in v3.9.x branch instead of main? |
4 of 6 tasks
Contributor
Author
|
I opened #20086 against v3.9.x with the same fix instead. Closing this one. |
3 of 6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Since #19838 the Liquid flow construct is allowed to interrupt a paragraph, so a line that merely starts with
{{ ... }}is torn out of the paragraph it belongs to:becomes two paragraphs with a blank line between them. This is what changed across MDN in v3.9.7.
{{ ... }}is an output expression, it is inline by nature, so it shouldn't end a paragraph any more than`code`does.{% ... %}is a tag and does start a block, which is what #19985 needs, so only that one keeps interrupting. Output for the case above is now byte-identical to 3.9.6 again.Fixes #20083
Checklist
docs/directory).changelog_unreleased/*/XXXX.mdfile followingchangelog_unreleased/TEMPLATE.md.