wip

phpstan · zonuexe · Sep 18, 2024 · Sep 19, 2024 · Sep 25, 2024 · Sep 26, 2024
commit e4e54cb87979a99832261ce73b744e217cf1ff77
diff --git a/src/Reflection/Annotations/AnnotationMethodReflection.php b/src/Reflection/Annotations/AnnotationMethodReflection.php
@@ -178,6 +178,11 @@ public function isPure(): TrinaryLogic
 		return TrinaryLogic::createMaybe();
 	}
 
+	public function getPureUnlessCallableIsImpureParameters(): array
+	{
+		return [];
+	}
+
 	public function getAttributes(): array
 	{
 		return [];

diff --git a/src/Reflection/Dummy/ChangedTypeMethodReflection.php b/src/Reflection/Dummy/ChangedTypeMethodReflection.php
@@ -165,6 +165,11 @@ public function isPure(): TrinaryLogic
 		return $this->reflection->isPure();
 	}
 
+	public function getPureUnlessCallableIsImpureParameters(): array
+	{
+		return [];
+	}
+
 	public function getAttributes(): array
 	{
 		return $this->reflection->getAttributes();

diff --git a/src/Reflection/Dummy/DummyConstructorReflection.php b/src/Reflection/Dummy/DummyConstructorReflection.php
@@ -152,6 +152,11 @@ public function isPure(): TrinaryLogic
 		return TrinaryLogic::createYes();
 	}
 
+	public function getPureUnlessCallableIsImpureParameters(): array
+	{
+		return [];
+	}
+
 	public function getAttributes(): array
 	{
 		return [];

diff --git a/src/Reflection/Dummy/DummyMethodReflection.php b/src/Reflection/Dummy/DummyMethodReflection.php
@@ -144,6 +144,11 @@ public function isPure(): TrinaryLogic
 		return TrinaryLogic::createMaybe();
 	}
 
+	public function getPureUnlessCallableIsImpureParameters(): array
+	{
+		return [];
+	}
+
 	public function getAttributes(): array
 	{
 		return [];

diff --git a/src/Reflection/ExtendedMethodReflection.php b/src/Reflection/ExtendedMethodReflection.php
@@ -60,6 +60,11 @@ public function isBuiltin(): TrinaryLogic|bool;
 	 */
 	public function isPure(): TrinaryLogic;
 
+	/**
+	 * @return array<string, bool>
+	 */
+	public function getPureUnlessCallableIsImpureParameters(): array;
+
 	/**
 	 * @return list<AttributeReflection>
 	 */

diff --git a/src/Reflection/FunctionReflection.php b/src/Reflection/FunctionReflection.php
@@ -57,6 +57,11 @@ public function returnsByReference(): TrinaryLogic;
 	 */
 	public function isPure(): TrinaryLogic;
 
+	/**
+	 * @return array<string, bool>
+	 */
+	public function getPureUnlessCallableIsImpureParameters(): array;
+
 	/**
 	 * @return list<AttributeReflection>
 	 */

diff --git a/src/Reflection/Native/NativeFunctionReflection.php b/src/Reflection/Native/NativeFunctionReflection.php
@@ -109,6 +109,11 @@ public function isPure(): TrinaryLogic
 		return $this->hasSideEffects->negate();
 	}
 
+	public function getPureUnlessCallableIsImpureParameters(): array
+	{
+		return [];
+	}
+
 	private function isVoid(): bool
 	{
 		foreach ($this->variants as $variant) {

diff --git a/src/Reflection/Native/NativeMethodReflection.php b/src/Reflection/Native/NativeMethodReflection.php
@@ -186,6 +186,11 @@ public function isPure(): TrinaryLogic
 		return $this->hasSideEffects->negate();
 	}
 
+	public function getPureUnlessCallableIsImpureParameters(): array
+	{
+		return [];
+	}
+
 	private function isVoid(): bool
 	{
 		foreach ($this->variants as $variant) {

diff --git a/src/Reflection/Php/ClosureCallMethodReflection.php b/src/Reflection/Php/ClosureCallMethodReflection.php
@@ -197,6 +197,11 @@ public function isPure(): TrinaryLogic
 		return $this->nativeMethodReflection->isPure();
 	}
 
+	public function getPureUnlessCallableIsImpureParameters(): array
+	{
+		return [];
+	}
+
 	public function getAttributes(): array
 	{
 		return $this->nativeMethodReflection->getAttributes();

diff --git a/src/Reflection/Php/EnumCasesMethodReflection.php b/src/Reflection/Php/EnumCasesMethodReflection.php
@@ -156,6 +156,11 @@ public function isPure(): TrinaryLogic
 		return TrinaryLogic::createYes();
 	}
 
+	public function getPureUnlessCallableIsImpureParameters(): array
+	{
+		return [];
+	}
+
 	public function getAttributes(): array
 	{
 		return [];

diff --git a/src/Reflection/Php/ExitFunctionReflection.php b/src/Reflection/Php/ExitFunctionReflection.php
@@ -138,6 +138,11 @@ public function isPure(): TrinaryLogic
 		return TrinaryLogic::createNo();
 	}
 
+	public function getPureUnlessCallableIsImpureParameters(): array
+	{
+		return [];
+	}
+
 	public function getAttributes(): array
 	{
 		return [];

diff --git a/src/Reflection/Php/PhpClassReflectionExtension.php b/src/Reflection/Php/PhpClassReflectionExtension.php
@@ -840,10 +840,13 @@ public function createUserlandMethodReflection(ClassReflection $fileDeclaringCla
 		$isInternal = $resolvedPhpDoc->isInternal();
 		$isFinal = $resolvedPhpDoc->isFinal();
 		$isPure = null;
+		$pureUnlessCallableIsImpureParameters = [];
 		foreach ($actualDeclaringClass->getAncestors() as $className => $ancestor) {
 			if ($this->signatureMapProvider->hasMethodMetadata($className, $methodReflection->getName())) {
-				$hasSideEffects = $this->signatureMapProvider->getMethodMetadata($className, $methodReflection->getName())['hasSideEffects'] ?? true;
+				$methodMetadata = $this->signatureMapProvider->getMethodMetadata($className, $methodReflection->getName());
+				$hasSideEffects = $methodMetadata['hasSideEffects'] ?? true;
 				$isPure = !$hasSideEffects;
+				$pureUnlessCallableIsImpureParameters += $methodMetadata['pureUnlessCallableIsImpureParameters'] ?? [];
 
 				break;
 			}
@@ -879,6 +882,7 @@ public function createUserlandMethodReflection(ClassReflection $fileDeclaringCla
 			$closureThisParameters,
 			$acceptsNamedArguments,
 			$this->attributeReflectionFactory->fromNativeReflection($methodReflection->getAttributes(), InitializerExprContext::fromClassMethod($actualDeclaringClass->getName(), $declaringTraitName, $methodReflection->getName(), $actualDeclaringClass->getFileName())),
+			$pureUnlessCallableIsImpureParameters,
 		);
 	}
 

diff --git a/src/Reflection/Php/PhpFunctionFromParserNodeReflection.php b/src/Reflection/Php/PhpFunctionFromParserNodeReflection.php
@@ -334,6 +334,11 @@ public function isPure(): TrinaryLogic
 		return TrinaryLogic::createFromBoolean($this->isPure);
 	}
 
+	public function getPureUnlessCallableIsImpureParameters(): array
+	{
+		return [];
+	}
+
 	public function getAttributes(): array
 	{
 		return $this->attributes;

diff --git a/src/Reflection/Php/PhpFunctionReflection.php b/src/Reflection/Php/PhpFunctionReflection.php
@@ -245,6 +245,11 @@ public function isPure(): TrinaryLogic
 		return TrinaryLogic::createFromBoolean($this->isPure);
 	}
 
+	public function getPureUnlessCallableIsImpureParameters(): array
+	{
+		return [];
+	}
+
 	public function isBuiltin(): bool
 	{
 		return $this->reflection->isInternal();

diff --git a/src/Reflection/Php/PhpMethodReflection.php b/src/Reflection/Php/PhpMethodReflection.php
@@ -71,7 +71,7 @@
 	 * @param array<string, Type> $phpDocClosureThisTypeParameters
 	 * @param list<AttributeReflection> $attributes
 	 */
 	public function __construct(
 		private InitializerExprTypeResolver $initializerExprTypeResolver,
 		private ClassReflection $declaringClass,
 		private ?ClassReflection $declaringTrait,
@@ -91,12 +91,13 @@
 		private ?bool $isPure,
 		private Assertions $asserts,
 		private bool $acceptsNamedArguments,
 		private ?Type $selfOutType,
 		private ?string $phpDocComment,
 		private array $phpDocParameterOutTypes,
 		private array $immediatelyInvokedCallableParameters,
 		private array $phpDocClosureThisTypeParameters,
 		private array $attributes,
+		private array $pureUnlessCallableIsImpureParameters,
 	)
 	{
 	}
@@ -110,7 +111,7 @@
 	{
 		return $this->declaringTrait;
 	}

 	/**
 	 * @return self|MethodPrototypeReflection
 	 */
@@ -452,6 +453,11 @@
 		return TrinaryLogic::createFromBoolean($this->isPure);
 	}
 
+	public function getPureUnlessCallableIsImpureParameters(): array
+	{
+		return $this->pureUnlessCallableIsImpureParameters;
+	}
+
 	public function changePropertyGetHookPhpDocType(Type $phpDocType): self
 	{
 		return new self(
@@ -479,6 +485,7 @@
 			$this->immediatelyInvokedCallableParameters,
 			$this->phpDocClosureThisTypeParameters,
 			$this->attributes,
+			$this->pureUnlessCallableIsImpureParameters,
 		);
 	}
 
@@ -512,6 +519,7 @@
 			$this->immediatelyInvokedCallableParameters,
 			$this->phpDocClosureThisTypeParameters,
 			$this->attributes,
+			$this->pureUnlessCallableIsImpureParameters,
 		);
 	}
 

diff --git a/src/Reflection/Php/PhpMethodReflectionFactory.php b/src/Reflection/Php/PhpMethodReflectionFactory.php
@@ -19,6 +19,7 @@ interface PhpMethodReflectionFactory
 	 * @param array<string, TrinaryLogic> $immediatelyInvokedCallableParameters
 	 * @param array<string, Type> $phpDocClosureThisTypeParameters
 	 * @param list<AttributeReflection> $attributes
+	 * @param array<string, bool> $pureUnlessCallableIsImpureParameters
 	 */
 	public function create(
 		ClassReflection $declaringClass,
@@ -41,6 +42,7 @@ public function create(
 		array $phpDocClosureThisTypeParameters,
 		bool $acceptsNamedArguments,
 		array $attributes,
+		array $pureUnlessCallableIsImpureParameters,
 	): PhpMethodReflection;
 
 }
diff --git a/src/Reflection/ResolvedMethodReflection.php b/src/Reflection/ResolvedMethodReflection.php
@@ -175,6 +175,11 @@ public function isPure(): TrinaryLogic
 		return $this->reflection->isPure();
 	}
 
+	public function getPureUnlessCallableIsImpureParameters(): array
+	{
+		return $this->reflection->getPureUnlessCallableIsImpureParameters();
+	}
+
 	public function getAsserts(): Assertions
 	{
 		return $this->asserts ??= $this->reflection->getAsserts()->mapTypes(fn (Type $type) => TemplateTypeHelper::resolveTemplateTypes(

diff --git a/src/Reflection/Type/IntersectionTypeMethodReflection.php b/src/Reflection/Type/IntersectionTypeMethodReflection.php
@@ -187,6 +187,11 @@ public function isPure(): TrinaryLogic
 		return TrinaryLogic::lazyMaxMin($this->methods, static fn (ExtendedMethodReflection $method): TrinaryLogic => $method->isPure());
 	}
 
+	public function getPureUnlessCallableIsImpureParameters(): array
+	{
+		return [];
+	}
+
 	public function getDocComment(): ?string
 	{
 		return null;

diff --git a/src/Reflection/Type/UnionTypeMethodReflection.php b/src/Reflection/Type/UnionTypeMethodReflection.php
@@ -170,6 +170,11 @@ public function isPure(): TrinaryLogic
 		return TrinaryLogic::lazyExtremeIdentity($this->methods, static fn (ExtendedMethodReflection $method): TrinaryLogic => $method->isPure());
 	}
 
+	public function getPureUnlessCallableIsImpureParameters(): array
+	{
+		return [];
+	}
+
 	public function getDocComment(): ?string
 	{
 		return null;

diff --git a/src/Reflection/WrappedExtendedMethodReflection.php b/src/Reflection/WrappedExtendedMethodReflection.php
@@ -143,6 +143,11 @@ public function isPure(): TrinaryLogic
 		return TrinaryLogic::createMaybe();
 	}
 
+	public function getPureUnlessCallableIsImpureParameters(): array
+	{
+		return [];
+	}
+
 	public function getAsserts(): Assertions
 	{
 		return Assertions::createEmpty();

diff --git a/src/Rules/RestrictedUsage/RewrittenDeclaringClassMethodReflection.php b/src/Rules/RestrictedUsage/RewrittenDeclaringClassMethodReflection.php
@@ -100,6 +100,11 @@ public function isPure(): TrinaryLogic
 		return $this->methodReflection->isPure();
 	}
 
+	public function getPureUnlessCallableIsImpureParameters(): array
+	{
+		return $this->methodReflection->getPureUnlessCallableIsImpureParameters();
+	}
+
 	public function getAttributes(): array
 	{
 		return $this->methodReflection->getAttributes();