Skip to content

Implement @pure-unless-callable-impure #3482

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
zonuexe wants to merge 10 commits into
base: 2.1.x
Choose a base branch
from
Draft

Implement @pure-unless-callable-impure #3482

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
f262eaa
wip
zonuexe Sep 18, 2024
a437d7d
Add pureUnlessCallableIsImpureParameters
zonuexe Sep 19, 2024
708023a
Add isPureUnlessCallableIsImpureParameter method
zonuexe Sep 25, 2024
b8e6162
Replace with $phpDocNode->getPureUnlessCallableIsImpureTagValues()
zonuexe Sep 26, 2024
29af2a1
Add pureUnlessCallableIsImpureParameters to functionMetadata
zonuexe Sep 30, 2024
55d3e87
Add pureUnlessCallableIsImpureParameters to functionMetadata_original…
zonuexe Sep 30, 2024
853e5bf
Fix
zonuexe Nov 19, 2024
c4999be
Fix
zonuexe Aug 1, 2025
1f66930
hasSideEffects default true
zonuexe Aug 1, 2025
e4e54cb
wip
zonuexe Aug 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix
  • Loading branch information
@zonuexe
zonuexe committed Aug 1, 2025
commit 853e5bf5fe81af5a06bbf6027b67f1cfe42d1d96
7 changes: 5 additions & 2 deletions src/Analyser/NodeScopeResolver.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5110,13 +5110,16 @@ private function processArgs(

if ($parameter instanceof ExtendedParameterReflection
&& $parameter->isPureUnlessCallableIsImpureParameter()
&& $parameterType !== null
&& $parameterType->isTrue()->yes()
) {
if (count($parameterType->getCallableParametersAcceptors($scope)) > 0) {
if (count($parameterType->getCallableParametersAcceptors($scope)) > 0 && $calleeReflection !== null) {
$parameterCallable = $parameterType->getCallableParametersAcceptors($scope)[0];
$certain = $parameterCallable->isPure()->yes();
if ($certain) {
$impurePoints[] = new SimpleImpurePoint(
$impurePoints[] = new ImpurePoint(
$scope,
$callLike,
'functionCall',
sprintf('call to function %s()', $calleeReflection->getName()),
$certain,
Expand Down