fix: skip user link for non-real users in processes list#20259
Open
mvanhorn wants to merge 1 commit intophpmyadmin:QA_5_2from
Open
fix: skip user link for non-real users in processes list#20259mvanhorn wants to merge 1 commit intophpmyadmin:QA_5_2from
mvanhorn wants to merge 1 commit intophpmyadmin:QA_5_2from
Conversation
Member
|
Thanks |
Do not render a link to the privileges page for pseudo-users like event_scheduler and unauthenticated user, since they have no corresponding entry in the user accounts table. Fixes phpmyadmin#19842 Signed-off-by: Matt Van Horn <mvanhorn@users.noreply.github.com> Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
6f7297c to
580546b
Compare
Author
|
Rebased onto QA_5_2 in 580546b. A straight rebase from master hit conflicts in |
Author
|
Thanks for the review! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The processes list currently links every user name to the privileges page.
Pseudo-users like
event_schedulerandunauthenticated userhave nocorresponding entry in the user accounts table, so the link leads to an
empty or broken page.
This extends the existing
system usercheck to also coverevent_schedulerandunauthenticated userby switching the conditionto a Twig
not inlist.Fixes #19842