Skip to content

fix(HamburgerIcon): Replace HamburgerIcon with RhUiStorageFillIcon#12479

Merged
nicolethoen merged 1 commit into
patternfly:mainfrom
rebeccaalpert:cursor/replace-hamburger-icon-with-rh-ui-storage-fill
Jun 17, 2026
Merged

fix(HamburgerIcon): Replace HamburgerIcon with RhUiStorageFillIcon#12479
nicolethoen merged 1 commit into
patternfly:mainfrom
rebeccaalpert:cursor/replace-hamburger-icon-with-rh-ui-storage-fill

Conversation

@rebeccaalpert

@rebeccaalpert rebeccaalpert commented Jun 16, 2026

Copy link
Copy Markdown
Member

Part of #12401. Breaking into separate PRs so it is easier to review.

Made with Cursor and manually reviewed site/code.

Summary by CodeRabbit

  • Documentation

    • Updated TreeView component example documentation with revised icon imports.
    • Enhanced example code to demonstrate updated icon usage patterns in tree action items.
  • Chores

    • Refreshed TreeView example components with current icon implementations.

@coderabbitai

coderabbitai Bot commented Jun 16, 2026

Copy link
Copy Markdown

Review Change Stack

Warning

Review limit reached

@rebeccaalpert, we couldn't start this review because you've reached your PR review rate limit.

More reviews will be available in 9 minutes and 2 seconds. Learn how PR review limits work.

Your organization has used up its prepaid credits, and credit purchases are no longer available. Enable the review add-on in the billing tab to keep reviews running — you're only billed for reviews past your plan's rate limits ($0.25/file).

⌛ How to resolve this issue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based credits.

🚦 How do rate limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan refill rate.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, the refill rate gradually slows as usage increases. The highest same-day bursts are limited more strictly.

Please see our Fair Usage Limits Policy for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 355f3625-9ca2-4d59-bd47-805757335474

📥 Commits

Reviewing files that changed from the base of the PR and between 7542e5f and 8eaa16b.

📒 Files selected for processing (2)
  • packages/react-core/src/components/TreeView/examples/TreeView.md
  • packages/react-core/src/components/TreeView/examples/TreeViewWithActionItems.tsx

Walkthrough

The TreeViewWithActionItems example replaces HamburgerIcon with RhUiStorageFillIcon as the action button icon for the "Application 2" tree item. The import statement in the TSX file and the icon import list in TreeView.md are updated accordingly.

Changes

TreeView Action Items Icon Replacement

Layer / File(s) Summary
Icon import and usage swap
packages/react-core/src/components/TreeView/examples/TreeViewWithActionItems.tsx, packages/react-core/src/components/TreeView/examples/TreeView.md
Replaces HamburgerIcon with RhUiStorageFillIcon in the component import and the "Application 2" action button render call; updates the corresponding icon import in the markdown documentation.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

Suggested reviewers

  • thatblindgeye
  • nicolethoen
  • kmcfaul
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main change: replacing HamburgerIcon with RhUiStorageFillIcon across the TreeView example files.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@rebeccaalpert rebeccaalpert marked this pull request as draft June 16, 2026 20:29
@patternfly-build

patternfly-build commented Jun 16, 2026

Copy link
Copy Markdown
Collaborator

@rebeccaalpert rebeccaalpert force-pushed the cursor/replace-hamburger-icon-with-rh-ui-storage-fill branch from c34951d to bac60e6 Compare June 16, 2026 20:36
@rebeccaalpert rebeccaalpert marked this pull request as ready for review June 16, 2026 20:36
@nicolethoen

Copy link
Copy Markdown
Contributor

needs rebase

@rebeccaalpert rebeccaalpert force-pushed the cursor/replace-hamburger-icon-with-rh-ui-storage-fill branch from bac60e6 to 7542e5f Compare June 17, 2026 17:52

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In
`@packages/react-core/src/components/TreeView/examples/TreeViewWithActionItems.tsx`:
- Line 86: The Button component on line 86 with the RhUiStorageFillIcon has an
aria-label attribute that says "Launch app 1" but this button is for
"Application 2", causing a mismatch that confuses assistive technology users.
Update the aria-label value to correctly reflect that this button is for
Application 2, making it say "Launch app 2" instead of "Launch app 1".
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: a61b069d-5ff8-456e-acd3-c7baa1ac31a3

📥 Commits

Reviewing files that changed from the base of the PR and between 256cd06 and 7542e5f.

📒 Files selected for processing (2)
  • packages/react-core/src/components/TreeView/examples/TreeView.md
  • packages/react-core/src/components/TreeView/examples/TreeViewWithActionItems.tsx

Comment thread packages/react-core/src/components/TreeView/examples/TreeViewWithActionItems.tsx Outdated
Co-authored-by: Cursor <cursoragent@cursor.com>
@rebeccaalpert rebeccaalpert force-pushed the cursor/replace-hamburger-icon-with-rh-ui-storage-fill branch from 7542e5f to 8eaa16b Compare June 17, 2026 18:11
@nicolethoen nicolethoen merged commit 68f2475 into patternfly:main Jun 17, 2026
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants