Skip to content

fix(EyeIcon): Replace EyeIcon with RhUiViewFillIcon#12473

Open
rebeccaalpert wants to merge 1 commit into
patternfly:mainfrom
rebeccaalpert:cursor/replace-eye-icon-with-rh-ui-view-fill
Open

fix(EyeIcon): Replace EyeIcon with RhUiViewFillIcon#12473
rebeccaalpert wants to merge 1 commit into
patternfly:mainfrom
rebeccaalpert:cursor/replace-eye-icon-with-rh-ui-view-fill

Conversation

@rebeccaalpert

@rebeccaalpert rebeccaalpert commented Jun 15, 2026 •
edited by coderabbitai Bot
Loading

Copy link
Copy Markdown
Member

What:
This is one piece of #12400. Breaking it up by icon so it is easier to review.

Additional issues:

Summary by CodeRabbit

  • Style
    • Updated the password visibility toggle icon appearance across login and password generator components for improved visual consistency.

@rebeccaalpert @cursoragent
fix(EyeIcon): Replace EyeIcon with RhUiViewFillIcon
9dc6a53 
Co-authored-by: Cursor <cursoragent@cursor.com>
@rebeccaalpert rebeccaalpert mentioned this pull request Jun 15, 2026
Open
30 tasks
@patternfly-build

patternfly-build commented Jun 15, 2026 •
edited
Loading

Copy link
Copy Markdown
Collaborator

Preview: https://pf-react-pr-12473.surge.sh

A11y report: https://pf-react-pr-12473-a11y.surge.sh

@coderabbitai

coderabbitai Bot commented Jun 15, 2026 •
edited
Loading

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 7099853e-b58f-4e38-8954-3d5980085f13

📥 Commits

Reviewing files that changed from the base of the PR and between 8b528bb and 9dc6a53.

⛔ Files ignored due to path filters (1)
  • packages/react-core/src/components/LoginPage/__tests__/__snapshots__/LoginForm.test.tsx.snap is excluded by !**/*.snap
📒 Files selected for processing (3)
  • packages/react-core/src/components/LoginPage/LoginForm.tsx
  • packages/react-core/src/demos/PasswordGenerator/PasswordGenerator.md
  • packages/react-core/src/demos/PasswordGenerator/examples/PasswordGenerator.tsx

Walkthrough

Replaces EyeIcon with RhUiViewFillIcon as the icon rendered when passwordHidden is true in the LoginForm component and the PasswordGenerator demo. The EyeSlashIcon for the opposite state is unchanged. The PasswordGenerator markdown documentation is updated to match.

Changes

Password visibility icon swap

Layer / File(s) Summary
LoginForm password-hidden icon update
packages/react-core/src/components/LoginPage/LoginForm.tsx		 Adds RhUiViewFillIcon import and substitutes it for EyeIcon in the toggle button's icon prop when passwordHidden is true.
PasswordGenerator demo and docs icon update
packages/react-core/src/demos/PasswordGenerator/examples/PasswordGenerator.tsx, packages/react-core/src/demos/PasswordGenerator/PasswordGenerator.md		 Replaces EyeIcon import with RhUiViewFillIcon in the demo component and its toggle button usage; updates the markdown doc import to match.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Suggested reviewers

  • wise-king-sullyman
  • kmcfaul
  • thatblindgeye
  • kaylachumley
  • nicolethoen
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main change: replacing EyeIcon with RhUiViewFillIcon across multiple files (LoginForm, PasswordGenerator demo, and PasswordGenerator example).
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@rebeccaalpert @patternfly-build