Skip to content

fix(EyeSlashIcon): Replace EyeSlashIcon with RhUiViewOffFillIcon #12472

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
rebeccaalpert wants to merge 1 commit into
base: main
Choose a base branch
from
+5 −5
Open

fix(EyeSlashIcon): Replace EyeSlashIcon with RhUiViewOffFillIcon #12472

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions packages/react-core/src/components/LoginPage/LoginForm.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,8 @@ import { Button } from '../Button';
import { Checkbox } from '../Checkbox';
import { ValidatedOptions } from '../../helpers/constants';
import { InputGroup, InputGroupItem } from '../InputGroup';
import EyeSlashIcon from '@patternfly/react-icons/dist/esm/icons/eye-slash-icon';
import EyeIcon from '@patternfly/react-icons/dist/esm/icons/eye-icon';
import RhUiViewOffFillIcon from '@patternfly/react-icons/dist/esm/icons/rh-ui-view-off-fill-icon';
import { HelperText, HelperTextItem } from '../HelperText';

export interface LoginFormProps extends Omit<React.HTMLProps<HTMLFormElement>, 'ref'> {
Expand Down Expand Up @@ -130,7 +130,7 @@ export const LoginForm: React.FunctionComponent<LoginFormProps> = ({
variant="control"
onClick={() => setPasswordHidden(!passwordHidden)}
aria-label={passwordHidden ? showPasswordAriaLabel : hidePasswordAriaLabel}
icon={passwordHidden ? <EyeIcon /> : <EyeSlashIcon />}
icon={passwordHidden ? <EyeIcon /> : <RhUiViewOffFillIcon />}
/>
</InputGroupItem>
</InputGroup>
Expand Down
2 changes: 1 addition & 1 deletion packages/react-core/src/demos/PasswordGenerator/PasswordGenerator.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ section: patterns
import { useEffect, useRef, useState } from 'react';
import RedoIcon from '@patternfly/react-icons/dist/esm/icons/redo-icon';
import EyeIcon from '@patternfly/react-icons/dist/esm/icons/eye-icon';
import EyeSlashIcon from '@patternfly/react-icons/dist/esm/icons/eye-slash-icon';
import RhUiViewOffFillIcon from '@patternfly/react-icons/dist/esm/icons/rh-ui-view-off-fill-icon';

## Demos

Expand Down
4 changes: 2 additions & 2 deletions packages/react-core/src/demos/PasswordGenerator/examples/PasswordGenerator.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ import {
} from '@patternfly/react-core';
import RedoIcon from '@patternfly/react-icons/dist/esm/icons/redo-icon';
import EyeIcon from '@patternfly/react-icons/dist/esm/icons/eye-icon';
import EyeSlashIcon from '@patternfly/react-icons/dist/esm/icons/eye-slash-icon';
import RhUiViewOffFillIcon from '@patternfly/react-icons/dist/esm/icons/rh-ui-view-off-fill-icon';

export const PasswordGenerator: React.FunctionComponent = () => {
const generatePassword = () => {
Expand Down Expand Up @@ -123,7 +123,7 @@ export const PasswordGenerator: React.FunctionComponent = () => {
variant="control"
onClick={() => setPasswordHidden(!passwordHidden)}
aria-label={passwordHidden ? 'Show password' : 'Hide password'}
icon={passwordHidden ? <EyeIcon /> : <EyeSlashIcon />}
icon={passwordHidden ? <EyeIcon /> : <RhUiViewOffFillIcon />}
/>
</InputGroupItem>
</InputGroup>
Expand Down
Loading