Skip to content

fix(EyeSlashIcon): Replace EyeSlashIcon with RhUiViewOffFillIcon#12472

Open
rebeccaalpert wants to merge 1 commit into
patternfly:mainfrom
rebeccaalpert:cursor/replace-eye-slash-icon-with-rh-ui-view-off-fill
Open

fix(EyeSlashIcon): Replace EyeSlashIcon with RhUiViewOffFillIcon#12472
rebeccaalpert wants to merge 1 commit into
patternfly:mainfrom
rebeccaalpert:cursor/replace-eye-slash-icon-with-rh-ui-view-off-fill

Conversation

@rebeccaalpert

@rebeccaalpert rebeccaalpert commented Jun 15, 2026 •
edited by coderabbitai Bot
Loading

Copy link
Copy Markdown
Member

What:
This is one piece of #12400. Breaking it up by icon so it is easier to review.

Additional issues:

Summary by CodeRabbit

  • Style
    • Updated the password visibility toggle icon in the login form and password generator components for visual consistency.

@rebeccaalpert @cursoragent
fix(EyeSlashIcon): Replace EyeSlashIcon with RhUiViewOffFillIcon
61b4f05 
Co-authored-by: Cursor <cursoragent@cursor.com>
@coderabbitai

coderabbitai Bot commented Jun 15, 2026 •
edited
Loading

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 3b20d219-3980-4329-90b3-d17500b97db7

📥 Commits

Reviewing files that changed from the base of the PR and between 8b528bb and 61b4f05.

📒 Files selected for processing (3)
  • packages/react-core/src/components/LoginPage/LoginForm.tsx
  • packages/react-core/src/demos/PasswordGenerator/PasswordGenerator.md
  • packages/react-core/src/demos/PasswordGenerator/examples/PasswordGenerator.tsx

Walkthrough

EyeSlashIcon is replaced with RhUiViewOffFillIcon as the icon rendered for the "hide password" toggle state. The change applies to the LoginForm component and the PasswordGenerator demo (both the .tsx example and .md documentation).

Changes

Icon Replacement: Password Visibility Toggle

Layer / File(s) Summary
LoginForm password toggle icon
packages/react-core/src/components/LoginPage/LoginForm.tsx		 Replaces EyeSlashIcon import with RhUiViewOffFillIcon and updates the toggle button's icon prop to render RhUiViewOffFillIcon when the password is visible.
PasswordGenerator demo icon
packages/react-core/src/demos/PasswordGenerator/examples/PasswordGenerator.tsx, packages/react-core/src/demos/PasswordGenerator/PasswordGenerator.md		 Replaces EyeSlashIcon import with RhUiViewOffFillIcon in the demo example and updates the toggle icon expression; updates the markdown documentation import accordingly.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Suggested labels

Needs design review

Suggested reviewers

  • wise-king-sullyman
  • nicolethoen
  • phcox
  • kmcfaul
  • thatblindgeye
  • kaylachumley
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main change: replacing EyeSlashIcon with RhUiViewOffFillIcon across the LoginForm component, PasswordGenerator demo, and related files.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@rebeccaalpert rebeccaalpert mentioned this pull request Jun 15, 2026
Open
30 tasks
@patternfly-build

patternfly-build commented Jun 15, 2026 •
edited
Loading

Copy link
Copy Markdown
Collaborator

Preview: https://pf-react-pr-12472.surge.sh

A11y report: https://pf-react-pr-12472-a11y.surge.sh

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@rebeccaalpert @patternfly-build