Follow LSP protocol when workspace folders are changed and adapt root workspace uri if folder is changed#754
Merged
Conversation
added 9 commits
February 24, 2020 17:52
…rver protocol V 3.15
Contributor
This was referenced May 10, 2020
Contributor
|
@andfoy, please review this one. |
andfoy
approved these changes
May 11, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If a workspace folder is changed via
m_workspace__did_change_workspace_foldersand the removed uri equals theroot uri, theroot_uriwill be adapted. Additional theself.workspacewill be reseted with a new Workspace which contains the workspace.The adoption of the
root_uriis necessary if a the root workspace folder changes and the jedi completion should use this new workspace folder.Fixes #720