Skip to content

Fix m_workspace__did_change_workspace_folders to follow the spec#749

Closed
zerocewl wants to merge 2 commits into
palantir:developfrom
zerocewl:DidChangeWorkspaceFolders
Closed

Fix m_workspace__did_change_workspace_folders to follow the spec#749
zerocewl wants to merge 2 commits into
palantir:developfrom
zerocewl:DidChangeWorkspaceFolders

Conversation

@zerocewl

@zerocewl zerocewl commented Feb 24, 2020

Copy link
Copy Markdown
Contributor

Changed signature for m_workspace__did_change_workspace_folders according to microsofts language-server-protocol DidChangeWorkspaceFolders.

see #720

@palantirtech

palantirtech commented Feb 24, 2020

Copy link
Copy Markdown
Member

Thanks for your interest in palantir/python-language-server, @zerocewl! Before we can accept your pull request, you need to sign our contributor license agreement - just visit https://cla.palantir.com/ and follow the instructions. Once you sign, I'll automatically update this pull request.

@zerocewl zerocewl mentioned this pull request Feb 24, 2020
Closed
@ccordoba12

ccordoba12 commented Feb 25, 2020

Copy link
Copy Markdown
Contributor

Does this fix #720?

@ccordoba12 ccordoba12 changed the title Adapted 'm_workspace__did_change_workspace_folders' to ms language se… Fix m_workspace__did_change_workspace_folders to follow the spec Feb 25, 2020
@ccordoba12

ccordoba12 commented Feb 25, 2020

Copy link
Copy Markdown
Contributor

@andfoy, please review this one.

@zerocewl

zerocewl commented Feb 25, 2020 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

@ccordoba12
It is only a partly fix, #720 addresses 3 different issues.
#750 and another fix for the pyls.workspace.root_uri handling is needed.

Are you sure that @andfoy is interested in handling this issue? It seems he never answered to your question in #720.

@zerocewl zerocewl mentioned this pull request Feb 25, 2020
Merged
@andfoy

andfoy commented Feb 25, 2020 •
edited
Loading

Copy link
Copy Markdown
Contributor

@zerocewl Sorry for not checking this discussion, it looks good to me. @ccordoba12 after this pyls release, we need to update spyder/spyder-ide/workspace.py

@goanpeca

goanpeca commented Feb 25, 2020

Copy link
Copy Markdown
Contributor

@andfoy please open a new issue on spyder to keep track of this and reference this issues. Thanks!

@ccordoba12 ccordoba12 added this to the 0.32.0 milestone Feb 26, 2020
@zerocewl zerocewl mentioned this pull request Feb 26, 2020
Closed
10 tasks
@zerocewl

zerocewl commented Feb 26, 2020 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

@andfoy please open a new issue on spyder to keep track of this and reference this issues. Thanks!

@goanpeca New spyder issue created. ✔️

@zerocewl zerocewl mentioned this pull request Feb 27, 2020
Closed
3 tasks
@ccordoba12 ccordoba12 removed this from the 0.32.0 milestone May 10, 2020
@ccordoba12

ccordoba12 commented May 10, 2020

Copy link
Copy Markdown
Contributor

Closing because this is included in #754.

@ccordoba12 ccordoba12 closed this May 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@zerocewl @palantirtech @ccordoba12 @andfoy @goanpeca