forked from HackYourFuture/JavaScript3
-
Notifications
You must be signed in to change notification settings - Fork 0
Apiweb3 #5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Apiweb3 #5
Changes from all commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
70dd82d
start from 0
outintotheblue 1edf4d1
week 1 js done
outintotheblue 7af7948
prettier
outintotheblue 85073fb
what i have so far
outintotheblue 6a231c8
main fix with repos
outintotheblue a947cf6
delete comments
outintotheblue 9234000
contribs fixed
outintotheblue d7c50e6
week 3 async done
outintotheblue f708f41
fixed index initialize
outintotheblue 7b5bd05
change class name
outintotheblue 3dba27e
showing details, changed css to read
outintotheblue 472bb94
cleaner
outintotheblue cda2588
container changed
outintotheblue File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,19 +1,26 @@ | ||
| 'use strict'; | ||
|
|
||
| /* global Util */ | ||
|
|
||
| // eslint-disable-next-line no-unused-vars | ||
| class Contributor { | ||
| constructor(contributor) { | ||
| this.contributor = contributor; | ||
| } | ||
|
|
||
| /** | ||
| * Render the contributor info to the DOM. | ||
| * @param {HTMLElement} container The container element in which to render the contributor. | ||
| */ | ||
| render(container) { | ||
| // TODO: replace the next line with your code. | ||
| Util.createAndAppend('pre', container, { text: JSON.stringify(this.contributor, null, 2) }); | ||
| const contributorsDiv = Util.createAndAppend('div', root, { id: 'contributorDiv' }); | ||
| Util.createAndAppend('img', container, { | ||
| src: this.contributor.avatar_url, | ||
| class: 'contributors-detail', | ||
| }); | ||
| Util.createAndAppend('p', container, { | ||
| text: this.contributor.login, | ||
| class: 'contributors-detail', | ||
| }); | ||
| Util.createAndAppend('p', container, { | ||
| text: this.contributor.contributions, | ||
| class: 'contributors-detail', | ||
| }); | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. You want to use the container :) |
||
| } | ||
| } | ||
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,27 +1,26 @@ | ||
| <!DOCTYPE html> | ||
| <html lang="en"> | ||
| <head> | ||
| <meta charset="UTF-8" /> | ||
| <meta | ||
| name="viewport" | ||
| content="width=device-width, initial-scale=1.0, maximum-scale=1.0, user-scalable=no" | ||
| /> | ||
| <meta name="theme-color" content="#000000" /> | ||
| <meta name="apple-mobile-web-app-capable" content="yes" /> | ||
| <meta name="mobile-web-app-capable" content="yes" /> | ||
| <meta name="format-detection" content="telephone=no" /> | ||
| <link rel="apple-touch-icon" href="./hyf.png" /> | ||
| <link rel="shortcut icon" type="image/png" href="./hyf.png" /> | ||
| <title>HYF-GITHUB</title> | ||
| <link href="https://fonts.googleapis.com/css?family=Roboto:400,700" rel="stylesheet" /> | ||
| <link rel="stylesheet" href="./style.css" /> | ||
| </head> | ||
|
|
||
| <body> | ||
| <div id="root"></div> | ||
| <script src="./Util.js"></script> | ||
| <script src="./Repository.js"></script> | ||
| <script src="./Contributor.js"></script> | ||
| <script src="./App.js"></script> | ||
| </body> | ||
| </html> | ||
| <head> | ||
| <meta charset="UTF-8" /> | ||
| <meta name="viewport" content="width=device-width, initial-scale=1.0, maximum-scale=1.0, user-scalable=no" /> | ||
| <meta name="theme-color" content="#000000" /> | ||
| <meta name="apple-mobile-web-app-capable" content="yes" /> | ||
| <meta name="mobile-web-app-capable" content="yes" /> | ||
| <meta name="format-detection" content="telephone=no" /> | ||
| <link rel="apple-touch-icon" href="./hyf.png" /> | ||
| <link rel="shortcut icon" type="image/png" href="./hyf.png" /> | ||
| <title>HYF-GITHUB</title> | ||
| <link href="https://fonts.googleapis.com/css?family=Roboto:400,700" rel="stylesheet" /> | ||
| <link rel="stylesheet" href="./style.css" /> | ||
| </head> | ||
|
|
||
| <body> | ||
| <div id="root"></div> | ||
| <script src="./Util.js"></script> | ||
| <script src="./Repository.js"></script> | ||
| <script src="./Contributor.js"></script> | ||
| <script src="./App.js"></script> | ||
| </body> | ||
|
|
||
| </html> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,3 +1,56 @@ | ||
| .alert-error { | ||
| color: red; | ||
| color: red; | ||
| } | ||
|
|
||
| body { | ||
| background-color: darkslategrey | ||
| } | ||
|
|
||
| h1 { | ||
| color: rgb(180, 244, 255); | ||
| font-family: Helvetica; | ||
| text-transform: uppercase; | ||
| text-align: center; | ||
| font-size: 3em; | ||
| } | ||
|
|
||
| #dropdown-select { | ||
| width: 25em; | ||
| height: 3em; | ||
| border-radius: 5px; | ||
| } | ||
|
|
||
| select { | ||
| width: 20em; | ||
| font-family: helvetica; | ||
| text-transform: uppercase; | ||
| position: relative; | ||
| color: rgb(13, 96, 110); | ||
| padding: 10px; | ||
| } | ||
|
|
||
| #root { | ||
| display: flex; | ||
| flex-direction: column; | ||
| flex-wrap: wrap; | ||
| } | ||
|
|
||
| img { | ||
| width: 50px; | ||
| } | ||
|
|
||
| #contributors { | ||
| display: flex; | ||
| flex-direction: row; | ||
| align-content: space-around; | ||
| margin-left: 35%; | ||
| flex-wrap: wrap; | ||
| list-style-type: none; | ||
| } | ||
|
|
||
| .contributors-detail { | ||
| color: white; | ||
| flex-wrap: wrap; | ||
| margin: 20px; | ||
| flex-grow: 1; | ||
| } |
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Problem is here! Cant seem to go through this part