Apiweb3#5
Merged
Merged
Conversation
grod220
reviewed
Aug 30, 2019
| for (let contributor of listOfContributors) { | ||
| Util.createAndAppend('img', contributors, { | ||
| src: this.contributor.avatar_url, | ||
| class: 'contri', |
There was a problem hiding this comment.
contri seems like a strange css class name. Can there be an alternative here?
outintotheblue
commented
Sep 6, 2019
| @@ -54,7 +55,7 @@ class App { | |||
| const repo = this.repos[index]; | |||
| const contributors = await repo.fetchContributors(); | |||
Owner
Author
There was a problem hiding this comment.
Problem is here! Cant seem to go through this part
grod220
reviewed
Sep 7, 2019
| function listenerSelect(listOfRepos) { | ||
| document.getElementById('dropdown-select').addEventListener('change', event => { | ||
| const selectedRepo = event.target.value; | ||
| const selectedData = listOfRepos.filter(repoData => repoData.name === selectedRepo)[0]; |
There was a problem hiding this comment.
This seems to be returning undefined every time. Think this is the source of the bug.
There was a problem hiding this comment.
The objects have a .repository field:
document.getElementById('dropdown-select').addEventListener('change', event => {
const selectedRepoName = event.target.value;
const selectedRepoData = this.repos.filter(
repoData => repoData.repository.name === selectedRepoName,
)[0];
const index = this.repos.indexOf(selectedRepoData);
this.fetchContributorsAndRender(index);
});
grod220
reviewed
Sep 7, 2019
| render(container) { | ||
| // TODO: replace the next line with your code. | ||
| Util.createAndAppend('pre', container, { text: JSON.stringify(this.repository, null, 2) }); | ||
| Util.createAndAppend('option', container, { |
There was a problem hiding this comment.
You'll have to add more here. Think you can copy code over from the previous week? Also, can't read if not white colored.
grod220
reviewed
Sep 7, 2019
| // TODO: replace the next line with your code. | ||
| Util.createAndAppend('pre', container, { text: JSON.stringify(this.contributor, null, 2) }); | ||
| const contributorsDiv = Util.createAndAppend('div', root, { id: 'contributors' }); | ||
| for (let contributor of listOfContributors) { |
There was a problem hiding this comment.
No need for loop here. One class, will be for one contributor. Can delete this line.
grod220
reviewed
Sep 7, 2019
| const rightDiv = Util.createAndAppend('div', container); | ||
|
|
||
| const contributorList = Util.createAndAppend('ul', contributorContainer); | ||
| const contributorList = Util.createAndAppend('ul', rightDiv); |
There was a problem hiding this comment.
I would probably make this a normal div because it will not just be text, but images too.
grod220
reviewed
Sep 7, 2019
| render(container) { | ||
| // TODO: replace the next line with your code. | ||
| Util.createAndAppend('pre', container, { text: JSON.stringify(this.contributor, null, 2) }); | ||
| const contributorsDiv = Util.createAndAppend('div', root, { id: 'contributors' }); |
grod220
reviewed
Sep 7, 2019
| Util.createAndAppend('pre', container, { text: JSON.stringify(this.contributor, null, 2) }); | ||
| const contributorsDiv = Util.createAndAppend('div', root, { id: 'contributors' }); | ||
| for (let contributor of listOfContributors) { | ||
| Util.createAndAppend('img', contributors, { |
There was a problem hiding this comment.
you'll want to do:
Util.createAndAppend('img', contributorDiv, {
grod220
reviewed
Sep 7, 2019
| class: 'contributors-detail', | ||
| }); | ||
| } | ||
| //Util.createAndAppend('pre', container, { text: JSON.stringify(this.contributor, null, 2) }); |
There was a problem hiding this comment.
You'll then want to do a normal append with what you created above. Something like:
container.appendChild(contributorDiv)
grod220
reviewed
Sep 10, 2019
| Util.createAndAppend('p', contributorDiv, { | ||
| text: this.contributor.contributions, | ||
| class: 'contributors-detail', | ||
| }); |
There was a problem hiding this comment.
You want to use the container :)
render(container) {
Util.createAndAppend('img', container, {
src: this.contributor.avatar_url,
class: 'contributors-detail',
});
Util.createAndAppend('p', container, {
text: this.contributor.login,
class: 'contributors-detail',
});
Util.createAndAppend('p', container, {
text: this.contributor.contributions,
class: 'contributors-detail',
});
}
}
grod220
approved these changes
Sep 10, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.