feat: Add ODP LRU Cache - #777
Merged
Merged
Conversation
Contributor
Author
|
Originally created React Native specific variations for AsyncStorage consideration, but since we're only concerned with an in-memory LRU Cache, will remove LRU Cache code specific to React Native. |
jaeopt
requested changes
Aug 22, 2022
jaeopt
left a comment
Contributor
There was a problem hiding this comment.
Looks good! A few small changes suggested.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
A generic LRU cache to support efficient caching of the ODP segments results.
Test plan
Added new unit tests files for Client/Server/React Native implementations.
Issues
OASIS-8410