feat: Added ODP Segment Manager Implementation - #790
Merged
Conversation
opti-jnguyen
force-pushed
the
jnguyen/odp-segment-manager
branch
from
October 25, 2022 10:02
369ac65 to
0af3793
Compare
Contributor
Author
|
@jaeopt / @zashraf1985 - updated and ready for review now. |
jaeopt
requested changes
Oct 25, 2022
jaeopt
left a comment
Contributor
There was a problem hiding this comment.
Looks good! A couple of restructuring/renaming requests. They can be addressed here or in other PRs.
zashraf1985
suggested changes
Oct 25, 2022
zashraf1985
left a comment
Contributor
There was a problem hiding this comment.
Looks Good overall, requested a few minor changes here and there. I have a question about the location of these classes though. I believe, we kept those things in plugins which will be injected from the entry points based on the platform. The OdpOption and OdpSegmentManager are core classes which are independent of the platforms. These can go inside core in my opinion.
zashraf1985
approved these changes
Nov 15, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
JavaScript implementation of the ODP segment manager.
Provides an internal API for fetching segments.
Includes OdpConfig, a class that represents a configuration used for ODP integration, and OdpOption, an enum that can hold one of two ODP option values for cache handling.
Additionally this PR includes a refactor of several previously implement ODP components including LRU Cache, the ODP Segment API Manager (previously GraphQL Manager), the ODP Events API Manager (previously Rest API Manager), etc. to proper folders and with refocused naming conventions as discussed with @jaeopt and @zashraf1985
Test plan
Issues