Pin conda version in miniconda_install#760
Merged
dwhswenson merged 2 commits intoJun 19, 2018
Merged
Conversation
Member
Author
|
Tests pass. If @jhprinz doesn't have a chance to review this by Sunday, 25 Feb 2018, at 22:00 CET, I'll merge it directly. If upstream (i.e., Continuum) fixes the fundamental problem with the incorrect hashes by then, I think the rename for clarity and making it easier to pin the miniconda version are still worth merging. |
Member
Author
|
The hashes have been updated, so I've started a PR for the 0.9.4 release that doesn't depend on this one. I'll remove the pin in this PR. As stated above, the other changes in here are probably worth merging. |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also, renamed
install.shtominiconda_install.shto be clearer.All our tests are failing right now because the
minicondaMD5 hash is wrong. For whatever reason, when they uploaded 4.4.10, the script linked bylatestgot updated, but all the metadata did not. Relevant lines from https://repo.continuum.io/miniconda/ as I see it now:Problem is, the script linked at
latestactually is4.4.10, so we find the MD5 hash for4.4.10while we're expecting (based on the table on the web site) to find the hash listed forlatest, which is the hash for4.3.31.This pin should be removed once conda fixes the problem. I tried to raise the issue on the Anaconda - Public Google group, but as of this writing my message has not gone through. If it doesn't by Monday, I'll raise the issue elsewhere, but I want to cut a release this weekend, and don't want to do that if tests are failing.