Skip to content

chore: Fix relative path to spec (in this release, regression from #515)#517

Merged
dbanty merged 1 commit intomainfrom
fix-relative-path-uri-parsing
Oct 17, 2021
Merged

chore: Fix relative path to spec (in this release, regression from #515)#517
dbanty merged 1 commit intomainfrom
fix-relative-path-uri-parsing

Conversation

@dbanty
Copy link
Copy Markdown
Collaborator

@dbanty dbanty commented Oct 17, 2021

FYI @tardyp the generator crashed when running against a spec that was a relative path 😬. Don't know why e2e tests didn't catch that, using the Path constructors there must make them absolute paths.

@codecov
Copy link
Copy Markdown

codecov Bot commented Oct 17, 2021

Codecov Report

Merging #517 (e78de23) into main (6e9d81f) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##              main      #517   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           48        48           
  Lines         1636      1636           
=========================================
  Hits          1636      1636           
Impacted Files Coverage Δ
openapi_python_client/__init__.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6e9d81f...e78de23. Read the comment docs.

@dbanty dbanty merged commit a55ac0f into main Oct 17, 2021
@dbanty dbanty deleted the fix-relative-path-uri-parsing branch October 17, 2021 03:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant