fix: properly support JSON OpenAPI documents and config files [#488, #509, #515]. Thanks @tardyp and @Gelbpunkt!#515
Merged
Conversation
json is not technically a subset of yaml because yaml don't support tabs while json does Signed-off-by: Pierre Tardy <pierre.tardy@renault.com>
json is not exactly a subset of yaml, as yaml do not support tabs there are maybe other subtleties, so we just use content-type to figure out how to parse Signed-off-by: Pierre Tardy <pierre.tardy@renault.com>
Codecov Report
@@ Coverage Diff @@
## main #515 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 48 48
Lines 1610 1628 +18
=========================================
+ Hits 1610 1628 +18
Continue to review full report at Codecov.
|
dbanty
added a commit
that referenced
this pull request
Oct 17, 2021
dbanty
added a commit
that referenced
this pull request
Oct 17, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adapted from #509, fixes #488. The YAML parsing library we use only supports YAML 1.1, which was not yet a superset of JSON. As a result, certain JSON features (like tabs as white space) are not working. This fixes that problem by using the builtin
jsonmodule for reading JSON files (after guessing the file type from file extension or mime type).