refactor(parser): move the pipe tokens in AST 1 element ahead#17977
Merged
WindSoilder merged 1 commit intonushell:mainfrom Apr 20, 2026
Merged
refactor(parser): move the pipe tokens in AST 1 element ahead#17977WindSoilder merged 1 commit intonushell:mainfrom
WindSoilder merged 1 commit intonushell:mainfrom
Conversation
Contributor
Author
|
@WindSoilder I think you're the expert of how pipes work in nushell, please take a look at this. Basically in |
Contributor
|
Where are we on this? Waiting for @WindSoilder or ready to land? |
Contributor
Author
Let's wait please. |
WindSoilder
approved these changes
Apr 20, 2026
Contributor
WindSoilder
left a comment
There was a problem hiding this comment.
Sorry for waiting! It looks good to me.
The pipe was required to belong to next command to make sure redirection works. But I believe it's no longer the case after #11934
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #17957
This could potentially be dangerous! I have no idea whether there're features implemented based on this bug/feature.
This has a hard conflict with #17932, and is better addressed before that.
Release notes summary - What our users need to know
Fixed a bug of lossy parsing of incomplete pipelines end with
|, which is noticeable via REPL highlighting.