fix(parser, highlighter): more consistent and accurate parsing/highlighting for erroneous pipe tokens.#17932
Draft
blindFS wants to merge 7 commits intonushell:mainfrom
Draft
fix(parser, highlighter): more consistent and accurate parsing/highlighting for erroneous pipe tokens.#17932blindFS wants to merge 7 commits intonushell:mainfrom
blindFS wants to merge 7 commits intonushell:mainfrom
Conversation
This reverts commit e5158af.
1 task
Contributor
|
is there any way to make these garbage/red at the same time e.g. when you finish typing it? On the incorrect ones, when I type another space and a character it turns red. 2> (correct)
out>| (incorrect)
o>| (incorrect)
2>&1 (incorrect)
|
Contributor
Author
|
@fdncred, that's a different issue, I'm afraid. Just like I didn't dig deep into that, but my hunch is that another dirty span hack might not be the best solution for that matter. |
2 tasks
Contributor
Author
|
@fdncred, I'll mark this PR as ready for review. But we can hold on to the merging in case someone would come up with a better solution. |
Contributor
|
@blindFS ok. Ping me when you're ready. |
WindSoilder
pushed a commit
that referenced
this pull request
Apr 20, 2026
Fixes #17957 This could potentially be dangerous! I have no idea whether there're features implemented based on this bug/feature. This has a hard conflict with #17932, and is better addressed before that. ## Release notes summary - What our users need to know Fixed a bug of lossy parsing of incomplete pipelines end with `|`, which is noticeable via REPL highlighting.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #17916
Closes #17951
A hack following this.
Release notes summary - What our users need to know
Fixed a bug of inconsistent parsing results for code snippets with
2>,out>|,o>|,2>or2>&1in them.Tasks after submitting
N/A