Skip to content

Use PlatformNames contants for platform exclusions #6606

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
0xced wants to merge 2 commits into
base: main
Choose a base branch
from
+7 −7
Open

Use PlatformNames contants for platform exclusions #6606

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b71abf8
Use PlatformNames contants for platform exclusions
0xced Jun 13, 2026
20581bb
Apply most Copilot suggestions manually
0xced Jun 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion test/Npgsql.Tests/ConnectionTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -526,7 +526,7 @@ public async Task Unix_domain_socket()
}

[Test]
[Platform(Exclude = "MacOsX", Reason = "Fails only on mac, needs to be investigated")]
[Platform(Exclude = PlatformNames.MacOSX, Reason = "Fails only on mac, needs to be investigated")]
public async Task Unix_abstract_domain_socket()
{
if (RuntimeInformation.IsOSPlatform(OSPlatform.Windows))
Expand Down
2 changes: 1 addition & 1 deletion test/Npgsql.Tests/CopyTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1326,7 +1326,7 @@ public async Task Copy_to_is_not_supported_in_regular_command_execution()
}

[Test, IssueLink("https://github.com/npgsql/npgsql/issues/5209")]
[Platform(Exclude = "MacOsX", Reason = "Write might not throw an exception")]
[Platform(Exclude = PlatformNames.MacOSX, Reason = "Write might not throw an exception")]
public async Task RawBinaryCopy_write_nre([Values] bool async)
{
await using var postmasterMock = PgPostmasterMock.Start(ConnectionString);
Expand Down
2 changes: 1 addition & 1 deletion test/Npgsql.Tests/MultipleHostsTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -241,7 +241,7 @@ public async Task Valid_host_not_found(TargetSessionAttributes targetSessionAttr
_ = await postmasters[i].WaitForServerConnection();
}

[Test, Platform(Exclude = "MacOsX", Reason = "#3786")]
[Test, Platform(Exclude = PlatformNames.MacOSX, Reason = "https://github.com/npgsql/npgsql/issues/3786")]
public void All_hosts_are_down()
{
var endpoint = new IPEndPoint(IPAddress.Loopback, 0);
Expand Down
8 changes: 4 additions & 4 deletions test/Npgsql.Tests/SecurityTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -254,7 +254,7 @@ public async Task Connect_with_only_ssl_allowed_user([Values] bool keepAlive)
}

[Test]
[Platform(Exclude = "Win", Reason = "Postgresql doesn't close connection correctly on windows which might result in missing error message")]
[Platform(Exclude = PlatformNames.Win, Reason = "PostgreSQL doesn't close connection correctly on Windows which might result in missing error message")]
public async Task Connect_with_only_non_ssl_allowed_user([Values] bool keepAlive)
{
try
Expand Down Expand Up @@ -513,7 +513,7 @@ public void Direct_ssl_requires_correct_sslmode([Values] SslMode sslMode)
}

[Test]
[Platform(Exclude = "MacOsX", Reason = "Mac requires explicit opt-in to receive CA certificate in TLS handshake")]
[Platform(Exclude = PlatformNames.MacOSX, Reason = "Mac requires explicit opt-in to receive CA certificate in TLS handshake")]
Comment thread
0xced marked this conversation as resolved.
public async Task Connect_with_verify_and_ca_cert([Values(SslMode.VerifyCA, SslMode.VerifyFull)] SslMode sslMode)
{
if (!IsOnBuildServer)
Expand All @@ -529,7 +529,7 @@ public async Task Connect_with_verify_and_ca_cert([Values(SslMode.VerifyCA, SslM
}

[Test]
[Platform(Exclude = "MacOsX", Reason = "Mac requires explicit opt-in to receive CA certificate in TLS handshake")]
[Platform(Exclude = PlatformNames.MacOSX, Reason = "Mac requires explicit opt-in to receive CA certificate in TLS handshake")]
Comment thread
0xced marked this conversation as resolved.
public async Task Connect_with_verify_check_host([Values(SslMode.VerifyCA, SslMode.VerifyFull)] SslMode sslMode)
{
if (!IsOnBuildServer)
Expand All @@ -554,7 +554,7 @@ public async Task Connect_with_verify_check_host([Values(SslMode.VerifyCA, SslMo
}

[Test]
[Platform(Exclude = "MacOsX", Reason = "Mac requires explicit opt-in to receive CA certificate in TLS handshake")]
[Platform(Exclude = PlatformNames.MacOSX, Reason = "Mac requires explicit opt-in to receive CA certificate in TLS handshake")]
Comment thread
0xced marked this conversation as resolved.
public async Task Connect_with_verify_and_multiple_ca_cert([Values(SslMode.VerifyCA, SslMode.VerifyFull)] SslMode sslMode, [Values] bool realCaFirst)
{
if (!IsOnBuildServer)
Expand Down
Loading